mail_room: Make it possible to configure delete after delivery behavior
What does this MR do and why?
In IMAP, delete_after_delivery
only marks the message as deleted,
but a separate expunge_deleted
step is needed to permanently remove
the message.
In Microsoft Graph, delete_after_delivery
soft-deletes the messages,
but the message is automatically expunged after a retention period,
typically 14 days. An admin can manually expunge deleted messages via
the command-line.
delete_after_delivery
has been set to true
since 712d1768 since it wasn't necessary to configure this for IMAP, but it is necessary for Microsoft Graph since this auto-expunge behavior may not be desired. We now make this option configurable with true
by default.
This requires Omnibus support: omnibus-gitlab!6605 (merged)
Relates to #386770 (closed)
Testing
With this merge request and omnibus-gitlab!6605 (merged) applied on an Omnibus instance, configure:
gitlab_rails['incoming_email_delete_after_delivery'] = false
Then run gitlab-ctl reconfigure
.
With this set to true
or omitted, the message is deleted:
With this set to false
, the message remains in the inbox:
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @stanhu
- A deleted user
added backend label
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/administration/incoming_email.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Michael Becker (
@wandering_person
) (UTC-8, same timezone as@stanhu
)Sean McGivern (
@smcgivern
) (UTC+0, 8 hours ahead of@stanhu
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User-
mentioned in issue #386770 (closed)
- Resolved by Stan Hu
@stanhu - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request.
added typefeature label
added 1 commit
- 1683b857 - mail_room: Make it possible to configure delete after delivery behavior
changed milestone to %15.8
added featureaddition label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added 1 commit
- cdf33b54 - mail_room: Make it possible to configure delete after delivery behavior
mentioned in merge request omnibus-gitlab!6605 (merged)
added grouprespond label
requested review from @bdenkovych and @cablett
added devopsmonitor sectionops labels
- A deleted user
added documentation label