Skip to content

Enforce memory-watchdog by default

Matthias Käppler requested to merge 386977-default-enable-watchdog into master

What does this MR do and why?

We recently rolled out a new memory killer, memory-watchdog, to replace and unify existing memory killers. As of 15.6 this was also enabled by default for Omnibus users (instead of Puma Worker Killer, the previous memory killer this replaced), but since its primary functionality was guarded by two different ops feature toggles that were only enabled on SaaS, it was not running by default for those users.

The two feature flags are:

  • gitlab_memory_watchdog: this was a general guard that stopped the watchdog from doing anything that we used to safely roll this out. I removed this since I don't think we need it anymore.
  • enforce_memory_watchdog: this is an ops toggle that "defuses" the watchdog to only log violations, but not enforce worker restarts. This is still useful to have and I merely changed this to be enabled by default.

Together these changes should ensure that the watchdog curbs memory use by default.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #386977 (closed)

Merge request reports