Show new "Your work" sidebar on Activity and Milestones dashboards
What does this MR do and why?
This builds on !107345 (merged), adding two more menu items to the new Your work sidebar (#384342 - closed):
- Milestones
- Activity
Screenshots or screen recordings
How to set up and validate locally
- Make sure you have the
your_work_sidebarfeature flag enabled:
Feature.enable(:your_work_sidebar)- While logged in, go to http://gdk.test:3000/dashboard/projects. This page should show the sidebar now and the Projects item should show as active.
- Navigate to "Milestones" from within the sidebar. The milestones dashboard should show and the sidebar menu item you've just clicked should now show as active.
- Do the same for "Activity".
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @thutterer
- A deleted user
added backend label
1 Warning 
featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message 
CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelogtrailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: truetrailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Corinna Gogolok (
@cwiesner) (UTC+1, same timezone as@thutterer)Mehmet Emin Inac (
@minac) (UTC+1, same timezone as@thutterer)test for spec/features/*Andrejs Cunskis (
@acunskis) (UTC+2, 1 hour ahead of@thutterer)Maintainer review is optional for test for spec/features/*To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Edited by Ghost User
Resolved by 🤖 GitLab Bot 🤖Proper labels assigned to this merge request. Please ignore me.
1 Error 
Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added featureaddition groupfoundations typefeature labels
added devopsmanage sectiondev labels
changed milestone to %15.8
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Last reply by Thomas Hutterer
requested review from @vsizov
-
@vsizov, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @vsizov
requested review from @mwoolf
removed review request for @mwoolf
requested review from @mwoolf
