Add a meaningful audit event name changes in Project CICD settings
What does this MR do and why?
This MR adds a meaningful audit event name in Project CICD settings when ever a setting is updated
Solves:
- Add a meaningful audit event name for `merge_pi... (#369316 - closed)
- Add a meaningful audit event name for `merge_tr... (#369317 - closed)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
- Setup audit event streaming on a group https://docs.gitlab.com/ee/administration/audit_event_streaming.html#add-a-new-streaming-destination
- Hint: use https://webhook.site/
- Create a new project https://docs.gitlab.com/ee/user/project/working_with_projects.html#create-a-project
- Change the settings for
Enable merged results pipelines
andEnable merge trains
https://docs.gitlab.com/ee/ci/pipelines/merged_results_pipelines.html#enable-merged-results-pipelines - Check audit event is streamed with correct event name.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #369317 (closed)
Merge request reports
Activity
assigned to @nrosandich
2 Warnings Please add a merge request subtype to this merge request. This merge request does not refer to an existing milestone. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Valery Sizov (
@vsizov
) (UTC+0)Mehmet Emin Inac (
@minac
) (UTC+1)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Nate Rosandich
@vsizov can you please review this for me?
requested review from @vsizov
@vsizov
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @vsizov
@mayra-cabrera can you please do the maintainer backend review?
requested review from @mayra-cabrera
- Resolved by Mayra Cabrera
Thanks @nrosandich! This LGTM, setting MWPS
enabled an automatic merge when the pipeline for f9a3be41 succeeds
removed Seeking community contributions label
mentioned in issue #369316 (closed)
mentioned in commit 44daeea6
added workflowstaging-canary label and removed workflowready for development label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
changed milestone to %15.8
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label