Skip to content

Temporarily vendors kubeclient gem

Thong Kuah requested to merge vendor_kubeclient_temporarily into master

What does this MR do and why?

See !106419 (merged) (original attempt), and !107167 (merged) (revert) for context.

Verification

The diff is too big, so the diff view is not showing everything (odd!). Reviewing commit by commit will be better

Comparing the vendored version to a cached version of the 4.9.3 gem:

$ diff -r /Users/tkuah/.rbenv/versions/2.7.7/lib/ruby/gems/2.7.0/gems/kubeclient-4.9.3/ vendor/gems/kubeclient/
Only in /Users/tkuah/.rbenv/versions/2.7.7/lib/ruby/gems/2.7.0/gems/kubeclient-4.9.3/.github/workflows: actions.yml
Only in /Users/tkuah/.rbenv/versions/2.7.7/lib/ruby/gems/2.7.0/gems/kubeclient-4.9.3/: .rubocop.yml
diff -r /Users/tkuah/.rbenv/versions/2.7.7/lib/ruby/gems/2.7.0/gems/kubeclient-4.9.3/kubeclient.gemspec vendor/gems/kubeclient/kubeclient.gemspec
17,18c17
<   git_files = `git ls-files -z`.split("\x0")
<   spec.files         = git_files.grep_v(%r{^(test|spec|features)/})
---
>   spec.files         = Dir.glob("lib/**/*.*")
25,26c24,25
<   spec.add_development_dependency 'rake', '~> 12.0'
<   spec.add_development_dependency 'minitest'
---
>   spec.add_development_dependency 'rake', '~> 13.0'
>   spec.add_development_dependency 'minitest', '~> 5.15.0'
39c38
<   spec.add_dependency 'http', '>= 3.0', '< 5.0'
---
>   spec.add_dependency 'http', '>= 3.0', '< 6.0'
diff -r /Users/tkuah/.rbenv/versions/2.7.7/lib/ruby/gems/2.7.0/gems/kubeclient-4.9.3/lib/kubeclient/version.rb vendor/gems/kubeclient/lib/kubeclient/version.rb
3c3
<   VERSION = '4.9.3'.freeze
---
>   VERSION = '4.9.4-gitlab1'.freeze
Only in vendor/gems/kubeclient/: test

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Thong Kuah

Merge request reports