Skip to content

Point kubeclient to new forked repo

Hunter Stewart requested to merge hustewart-forked-kubeclient-dep-update into master

What does this MR do and why?

The kubeclient gem has some dependencies that we'd like to see updated. On GitHub where the gem's git repository resides, the master branch has the dependencies updated, but the change has not yet been published to RubyGems. Ordinarily, we don't fetch gems from git repositories, but in this case I have forked the relevant repository myself and would like for us to consider using this version until the kubeclient gem is able to publish a release to RubyGems, at which point we can switch back.

This MR points the gem to a specific ref in the forked repo that includes the minimal amount of dependency updates possible. To create this change I checked out the version that we are on (v4.9.3) and updated the dependencies, ensured tests pass for the gem. Note that the rubocop run fails within the gem, but I wanted to keep the diff as small as possible for the short term switch so I have left that alone. This is the diff from our current version to the new one this merge request points to

Once a release is published by the maintainer, we can move back to using the gem from RubyGems.

License Note

The llhttp dependency is introduced by the update to http-rb

bundle exec license_finder

Dependencies that need approval:
llhttp-ffi, 0.4.0, "Mozilla Public License 2.0"

The update to http-rb is one of the main things we're after in this Merge Request. That update introduces a new dependency that has a license that is not yet allow-listed. I would love to get input from reviews/maintainers about whether allow-listing this is acceptable. Our other options would be to abandon this approach altogether and look for something that replaces kubeclient that does not introduce a new type of license.

[UPDATE] - the usage of the gem was approved in this issue

Screenshot of dependency graph

Screen_Shot_2022-12-08_at_7.18.19_AM

Edited by Hunter Stewart

Merge request reports