Replace housekeeping setting with a single one in API
What does this MR do and why?
Instead of three housekeeping options (housekeeping_full_repack_period
, housekeeping_gc_period
, housekeeping_incremental_repack_period
), that are responsible for calling deprecated housekeeping RPCs, now we have a single housekeeping_optimize_repository_period
.
It's an alias attribute for housekeeping_optimize_repository_period
and all the existing applications will use that value to decided how often OptimizeRepository RPC must be called.
Related issue: #353778 (closed)
Merge request reports
Activity
changed milestone to %15.8
assigned to @igor.drozdov
added devopscreate sectiondev labels
- A deleted user
added documentation label
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/api/settings.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Max Fan (
@mfangitlab
) (UTC-8, 9 hours behind@igor.drozdov
)Doug Stull (
@dstull
) (UTC-5, 6 hours behind@igor.drozdov
)frontend Artur Fedorov (
@arfedoro
) (UTC+1, same timezone as@igor.drozdov
)Simon Knox (
@psimyn
) (UTC+11, 10 hours ahead of@igor.drozdov
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
mentioned in merge request !106741 (merged)
added 2035 commits
-
18f2660b...e020ee83 - 2034 commits from branch
master
- 5619e2b4 - Replace housekeeping setting with a single one in API
-
18f2660b...e020ee83 - 2034 commits from branch
- Resolved by Doug Stull
@mcelicalderonG could you please review from backend perspective?
@aqualls could you please review from documentation perspective?
requested review from @aqualls and @mcelicalderonG
@mcelicalderonG
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @dstull and removed review request for @mcelicalderonG
- Resolved by Igor Drozdov
removed review request for @dstull
mentioned in merge request !108170 (merged)
added Technical Writing docsfeature tw-weight3 twdoing labels
added 142 commits
-
5619e2b4...9307453c - 141 commits from branch
master
- d35ace9f - Replace housekeeping setting with a single one in API
-
5619e2b4...9307453c - 141 commits from branch
requested review from @dstull
- A deleted user
added frontend label
enabled an automatic merge when the pipeline for b53916c9 succeeds
mentioned in commit 36f0e564
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1829 (merged)
added releasedpublished label and removed releasedcandidate label