Skip to content
Snippets Groups Projects

Update required node version to 18.16.0 or later

Merged Lukas Eipert requested to merge leipert-node-18-upgrade into master

What does this MR do and why?

See &9477 (closed). node@18 is the latest LTS and the new version has some nice features we might end up using (e.g. more parity on the Intl API with browsers).

In order to ensure that node version bump result in re-compiling of assets, we also tell the asset hashing that any change in .nvmrc requires a full recompilation.

Screenshots or screen recordings

N/A

How to set up and validate locally

  1. asdf install
  2. run jest, eslint, webpack jobs.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lukas Eipert

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Allure report

    allure-report-publisher generated test report!

    e2e-review-qa: :exclamation: test report for e93995b4

    expand test summary
    +-------------------------------------------------------------+
    |                       suites summary                        |
    +--------+--------+--------+---------+-------+-------+--------+
    |        | passed | failed | skipped | flaky | total | result |
    +--------+--------+--------+---------+-------+-------+--------+
    | Manage | 39     | 0      | 4       | 7     | 43    | ❗     |
    +--------+--------+--------+---------+-------+-------+--------+
    | Total  | 39     | 0      | 4       | 7     | 43    | ❗     |
    +--------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :exclamation: test report for e93995b4

    expand test summary
    +---------------------------------------------------------------------------+
    |                              suites summary                               |
    +----------------------+--------+--------+---------+-------+-------+--------+
    |                      | passed | failed | skipped | flaky | total | result |
    +----------------------+--------+--------+---------+-------+-------+--------+
    | Manage               | 369    | 0      | 27      | 13    | 396   | ❗     |
    | Configure            | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Create               | 16     | 0      | 2       | 0     | 18    | ✅     |
    | Verify               | 4      | 0      | 2       | 0     | 6     | ✅     |
    | Plan                 | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Version sanity check | 0      | 0      | 2       | 2     | 2     | ➖     |
    | Govern               | 4      | 0      | 0       | 0     | 4     | ✅     |
    +----------------------+--------+--------+---------+-------+-------+--------+
    | Total                | 402    | 0      | 33      | 15    | 435   | ❗     |
    +----------------------+--------+--------+---------+-------+-------+--------+
  • Setting label groupfoundations based on @leipert's group.

  • Lukas Eipert added 700 commits

    added 700 commits

    Compare with previous version

  • A deleted user added documentation label

    added documentation label

  • Lukas Eipert added 1 commit

    added 1 commit

    • e93995b4 - Update required node version to 18.12.1 or later

    Compare with previous version

  • Lukas Eipert changed title from Update node version to 18.12.1 to Update required node version to 18.12.1 or later

    changed title from Update node version to 18.12.1 to Update required node version to 18.12.1 or later

  • Lukas Eipert changed the description

    changed the description

  • Lukas Eipert changed milestone to %15.8

    changed milestone to %15.8

  • mentioned in issue #385512 (closed)

  • 🤖 GitLab Bot 🤖 changed milestone to %15.9

    changed milestone to %15.9

  • changed milestone to %15.10

  • closed

  • Author Maintainer

    Closing for now

  • reopened

  • Lukas Eipert changed title from Update required node version to 18.12.1 or later to Update required node version to 18.16.0 or later

    changed title from Update required node version to 18.12.1 or later to Update required node version to 18.16.0 or later

  • removed missed:15.9 label

  • removed missed:15.8 label

  • Lukas Eipert added 22634 commits

    added 22634 commits

    Compare with previous version

  • Lukas Eipert changed milestone to %16.0

    changed milestone to %16.0

  • requested review from @vitallium, @ddieulivol, and @stanhu

  • Contributor
    1 Message
    :book: This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

    Documentation review

    The following files require a review from a technical writer:

    The review does not need to block merging this merge request. See the:

    Pipeline Changes

    This merge request contains changes to the pipeline configuration for the GitLab project.

    Please consider the effect of the changes in this merge request on the following:

    Please consider communicating these changes to the broader team following the communication guideline for pipeline changes

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Mohamed Hamda current availability (@mhamda) (UTC+2, same timezone as @leipert) Fabio Pitino current availability (@fabiopitino) (UTC+1, 1 hour behind @leipert)
    frontend Elwyn Benson current availability (@elwyn-gitlab) (UTC+12, 10 hours ahead of @leipert) Paul Gascou-Vaillancourt current availability (@pgascouvaillancourt) (UTC-4, 6 hours behind @leipert)
    maintenanceworkflow / maintenancepipelines for CI, Danger Adam Hegyi current availability (@ahegyi) (UTC+2, same timezone as @leipert) David Dieulivol current availability (@ddieulivol) (UTC+2, same timezone as @leipert)
    Engineering Productivity Reviewer review is optional for Engineering Productivity Rémy Coutable current availability (@rymai) (UTC+2, same timezone as @leipert)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Stan Hu
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading