Update required node version to 18.16.0 or later
What does this MR do and why?
See &9477 (closed). node@18 is the latest LTS and the new version has some nice features we might end up using (e.g. more parity on the Intl API with browsers).
In order to ensure that node version bump result in re-compiling of assets, we also tell the asset hashing that any change in .nvmrc requires a full recompilation.
Screenshots or screen recordings
N/A
How to set up and validate locally
- asdf install
- run jest, eslint, webpack jobs.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @leipert
added frontend maintenancedependency labels
added typemaintenance label
changed milestone to %15.7
mentioned in epic &9477 (closed)
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/install/installation.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Pipeline Changes
This merge request contains changes to the pipeline configuration for the GitLab project.
Please consider the effect of the changes in this merge request on the following:
- Effects on different pipeline types
- Effects on non-canonical projects:
gitlab-foss
security
dev
- personal forks
- Effects on pipeline performance
Please consider communicating these changes to the broader team following the communication guideline for pipeline changes
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Alex Buijs (
@alexbuijs
) (UTC+1, same timezone as@leipert
)Stan Hu (
@stanhu
) (UTC-8, 9 hours behind@leipert
)frontend Scott de Jonge (
@sdejonge
) (UTC+11, 10 hours ahead of@leipert
)Alexander Turinske (
@aturinske
) (UTC+9, 8 hours ahead of@leipert
)maintenanceworkflow / maintenancepipelines for CI, Danger Jay Montal (
@jmontal
) (UTC-7, 8 hours behind@leipert
)David Dieulivol (
@ddieulivol
) (UTC+1, same timezone as@leipert
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@4504c764
removed pipeline:run-as-if-jh label
- A deleted user
added backend label
- Resolved by Lukas Eipert
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for e93995b4expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Manage | 39 | 0 | 4 | 7 | 43 | ❗ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 39 | 0 | 4 | 7 | 43 | ❗ | +--------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for e93995b4expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Manage | 369 | 0 | 27 | 13 | 396 | ❗ | | Configure | 1 | 0 | 0 | 0 | 1 | ✅ | | Create | 16 | 0 | 2 | 0 | 18 | ✅ | | Verify | 4 | 0 | 2 | 0 | 6 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Version sanity check | 0 | 0 | 2 | 2 | 2 | ➖ | | Govern | 4 | 0 | 0 | 0 | 4 | ✅ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 402 | 0 | 33 | 15 | 435 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
Setting label groupfoundations based on
@leipert
's group.added groupfoundations label
Setting label(s) devopsmanage sectiondev based on groupfoundations.
added devopsmanage sectiondev labels
added 700 commits
-
dce00a85...4a2d8154 - 699 commits from branch
master
- 088f5ddd - Update required node version to 18.12.1 or later
-
dce00a85...4a2d8154 - 699 commits from branch
- A deleted user
added documentation label
added 1 commit
- e93995b4 - Update required node version to 18.12.1 or later
changed milestone to %15.8
- Resolved by Lukas Eipert
mentioned in issue #385512 (closed)
mentioned in issue gitlab-org/quality/triage-reports#10902 (closed)
changed milestone to %15.9
added missed:15.8 label
mentioned in issue gitlab-org/quality/triage-reports#11137 (closed)
changed milestone to %15.10
added missed:15.9 label
mentioned in issue gitlab-org/quality/triage-reports#11315 (closed)
mentioned in issue gitlab-org/quality/triage-reports#11522 (closed)
removed missed:15.9 label
removed missed:15.8 label
added 22634 commits
-
e93995b4...52209157 - 22633 commits from branch
master
- 75e073a0 - Update required node version to 18.16.0 or later
-
e93995b4...52209157 - 22633 commits from branch
- Resolved by Vitaly Slobodin
@vitallium / @ddieulivol / @stanhu Could you review frontend maintenancepipelines backend respectively?
Do we maybe want to hold off until %16.0 is cut and we are in %16.1, wdyt?
changed milestone to %16.0
requested review from @vitallium, @ddieulivol, and @stanhu
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/install/installation.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Pipeline Changes
This merge request contains changes to the pipeline configuration for the GitLab project.
Please consider the effect of the changes in this merge request on the following:
- Effects on different pipeline types
- Effects on non-canonical projects:
gitlab-foss
security
dev
- personal forks
- Effects on pipeline performance
Please consider communicating these changes to the broader team following the communication guideline for pipeline changes
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Mohamed Hamda (
@mhamda
) (UTC+2, same timezone as@leipert
)Fabio Pitino (
@fabiopitino
) (UTC+1, 1 hour behind@leipert
)frontend Elwyn Benson (
@elwyn-gitlab
) (UTC+12, 10 hours ahead of@leipert
)Paul Gascou-Vaillancourt (
@pgascouvaillancourt
) (UTC-4, 6 hours behind@leipert
)maintenanceworkflow / maintenancepipelines for CI, Danger Adam Hegyi (
@ahegyi
) (UTC+2, same timezone as@leipert
)David Dieulivol (
@ddieulivol
) (UTC+2, same timezone as@leipert
)Engineering Productivity Reviewer review is optional for Engineering Productivity Rémy Coutable (
@rymai
) (UTC+2, same timezone as@leipert
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
- Resolved by Vitaly Slobodin
- Resolved by Vitaly Slobodin
Do we also need to update https://gitlab.com/gitlab-org/gitlab-omnibus-builder/-/blob/31221f750b3cfc8386ea60ec1c4794f5368a9227/docker/VERSIONS#L9?
Ok, I see it's a part of &9477 (closed).
Edited by Stan Hu