Return HTTP 400 for multipart header without boundary

If the client passes a multipart/form-data content type without a boundary, Workhorse would return an HTTP 500 status code (Internal Server Error). This should be status 400 (Bad Request). This helps the user because it tells them the problem is on their end (in the request) and not on the GitLab server.

Fixes #385112 (closed).

assigned to @jacobvosmaer-gitlab

added typebug label

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
workhorse	Ash McKenzie (@ashmckenzie) (UTC+11, 10 hours ahead of @jacobvosmaer-gitlab)	Alessio Caiazza (@nolith) (UTC+1, same timezone as @jacobvosmaer-gitlab)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added bugfunctional label

changed milestone to %15.7

added 1 commit

• ec5246be - Return HTTP 400 for multipart header without boundary

Compare with previous version

Setting label groupscalability based on @jacobvosmaer-gitlab's group.

added groupscalability label

requested review from @ashmckenzie

added devopsplatforms sectionplatforms labels

mentioned in merge request !106182 (merged)

Just one question @jacobvosmaer-gitlab

resolved all threads

Asking for maintainer review as there are no available workhorse maintainers atm.

approved this merge request

@ashmckenzie, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

For more info, please refer to the following links:

• rspec minimal jobs
• jest minimal jobs
• merging a merge request.

added pipeline:mr-approved label

requested review from @nolith

approved this merge request