Disable query limits for some additional specs in spec/features/boards/boards_spec.rb
What does this MR do and why?
Use
inspect_requests(inject_headers: { 'X-GITLAB-DISABLE-SQL-QUERY-LIMIT' => 'https://gitlab.com/gitlab-org/gitlab/-/issues/323426' })
to disable all query checks in https://gitlab.com/gitlab-org/gitlab/blob/master/spec/features/boards/boards_spec.rb
This is because we're seeing flaky behavior with these specs. Already many of the tests in this file disable the query count. Here we will extend that to all of them in order to avoid the random failures in CI.
Example failures in CI:
- https://gitlab.com/gitlab-org/gitlab/-/jobs/3415383179
- https://gitlab.com/gitlab-org/gitlab/-/jobs/3410190558
The tests themselves are not being quarantined, just the SQL query limit check is being disabled.
See also !105849 (comment 1197129526), where it seems like let_it_be
may be the main culprit.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Brett Walker