Skip to content
Snippets Groups Projects

Introduce security report diffs

Merged Olivier Gonzalez requested to merge 7586-introduce_reports_diff into master

What does this MR do?

Introduce security report diffs.

  • Allow to compare two reports to get the list of added, existing, and fixed vulnerabilities.
  • Provides a Security::CompareReportsBaseService that relies on primary identifier and location fingeprints to compare vulnerabilities.
  • Provides a Security::CompareReportsSastService that leverages the git diff to improve matching for SAST reports.

This is a preliminary step (#3) for upcoming changes regarding https://gitlab.com/gitlab-org/gitlab-ee/issues/7586

List of MRs:

  1. Use POROs for security report vulnerabilities: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10417
  2. Add locations POROs for vulnerabilities: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10508
  3. Introduce security report diffs: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10559

What are the relevant issue numbers?

#7586 (closed)

Does this MR meet the acceptance criteria?

Edited by Olivier Gonzalez

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

    Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

    Category Reviewer Maintainer
    backend Imre Farkas (@ifarkas) Sean McGivern (@smcgivern)

    Generated by :no_entry_sign: Danger

    Edited by 🤖 GitLab Bot 🤖
  • @engwan could you please review this MR? Thanks

    /cc @brytannia for the domain logic.

    Edited by Olivier Gonzalez
  • assigned to @engwan

  • Looks good @gonzoyumo! Just a few suggestions on naming.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading