ChatNames::FindUserService to not take integration
What does this MR do and why?
ChatNames::FindUserService was changed in !103478 (merged) to not necessarily need an Integration to find the ChatName record.
The integration is always irrelevant (related to #357221 (closed)) and so we can refactor the class to not ever take an integration.
QA the change
This should be a pure refactor and have no functional changes.
The follow steps should work the same on master as this branch.
To QA this feature you must have access to the Ecosystem Test Slack Workspace.
- Start a new GitPod instance and configure the GitLab for Slack (dev) app to work with it (docs)
- Checkout this feature branch,
bundleandyarn, and restart GDK (docs) - Choose a project, and set up the GitLab for Slack integration.
- Once set up, these should still work:
- In a Slack channel of the workspace:
/gitlab-dev <project path> issue show 1should prompt you to authorize yourself. - The authorization flow should work.
- Afterwards,
/gitlab-dev <project path> issue show 1should show an issue in the reply (or reply with a not found message if an issue with IID1doesn't exist).
- In a Slack channel of the workspace:
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #383989 (closed)
Edited by Luke Duncalfe