Skip to content
Snippets Groups Projects

Hide marketing-related entries

All threads resolved!

Related to Not work " Hide marketing-related entries from... (#383738 - closed)

What does this MR do and why?

Show marketing related header entries only for SaaS

Screenshots or screen recordings

SaaS NOT SaaS
Screenshot_2022-11-28_at_15.33.29 Screenshot_2022-11-28_at_15.39.24

How to set up and validate locally

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Merged results pipeline #712043268 passed

Pipeline: GitLab

#712045200

    Merged results pipeline passed for 8ca50fc0

    Test coverage 83.68% (11.52%) from 2 jobs
    Approved by

    Merged by Doug StullDoug Stull 2 years ago (Dec 2, 2022 8:42pm UTC)

    Pipeline #712102233 passed

    Pipeline passed for 093807b1 on master

    Test coverage 72.15% (11.52%) from 2 jobs
    10 environments impacted.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Max Orefice approved this merge request

    approved this merge request

  • Max Orefice requested review from @dstull and removed review request for @morefice

    requested review from @dstull and removed review request for @morefice

  • added 391 commits

    Compare with previous version

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 9b96bd36 and b52597fc

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.45 MB 3.45 MB - 0.0 %
    mainChunk 1.86 MB 1.86 MB - 0.0 %

    Note: We do not have exact data for 9b96bd36. So we have used data from: 2332ae4d.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Thanks for creating this @syarynovskyi. In terms of the fix, I think we should keep the marketing header in the SM docs but we should honor the "disable marketing links" setting value.

    • If an instance has selected to "disable marketing links" then we should not display marketing links in the nav
    • If an instance has not selected to "disable marketing links" then we should display marketing links in the nav
  • Allure report

    allure-report-publisher generated test report!

    e2e-review-qa: :exclamation: test report for b52597fc

    expand test summary
    +-----------------------------------------------------------------------------------------+
    |                                     suites summary                                      |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    |                                    | passed | failed | skipped | flaky | total | result |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Govern                             | 6      | 0      | 0       | 1     | 6     | ❗     |
    | Plan                               | 33     | 0      | 1       | 0     | 34    | ✅     |
    | Configure                          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Feature flag handler sanity checks | 9      | 0      | 0       | 0     | 9     | ✅     |
    | Create                             | 18     | 0      | 1       | 0     | 19    | ✅     |
    | Manage                             | 19     | 0      | 3       | 2     | 22    | ❗     |
    | Verify                             | 11     | 0      | 1       | 0     | 12    | ✅     |
    | Version sanity check               | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Total                              | 96     | 0      | 8       | 3     | 104   | ❗     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
  • marked this merge request as draft

  • Serhii Yarynovskyi Parental Leave from 2025-02-21 to 2025-06-09 changed the description

    changed the description

  • added 95 commits

    Compare with previous version

  • Ghost User
    • Resolved by Doug Stull

      Proposed hint text to provide more context to the user on what this setting actually controls

      "“This setting will remove links the GitLab marketing site from the help documentation and navigation"

      @phillipwells for your review

  • Phillip Wells added Technical Writing UI text + 1 deleted label and removed 1 deleted label

    added Technical Writing UI text + 1 deleted label and removed 1 deleted label

  • added 1 commit

    • b52597fc - Revert "Use help_page_hide_commercial_content setting for header"

    Compare with previous version

  • marked this merge request as ready

  • added severity4 label

  • Doug Stull
  • Doug Stull requested review from @vvempati

    requested review from @vvempati

  • Doug Stull removed review request for @dstull

    removed review request for @dstull

  • Vamsi Vempati approved this merge request

    approved this merge request

  • Vamsi Vempati requested review from @ntepluhina

    requested review from @ntepluhina

  • added 1 commit

    • c44caf52 - Move marketing header class back to foss

    Compare with previous version

  • Natalia Tepluhina approved this merge request

    approved this merge request

  • Natalia Tepluhina removed review request for @ntepluhina

    removed review request for @ntepluhina

  • Doug Stull
  • added 1 commit

    • 46c01551 - Move marketing header class back to foss

    Compare with previous version

  • requested review from @dstull and removed review request for @vvempati

  • Doug Stull approved this merge request

    approved this merge request

  • Doug Stull resolved all threads

    resolved all threads

  • Doug Stull enabled an automatic merge when the pipeline for 8ca50fc0 succeeds

    enabled an automatic merge when the pipeline for 8ca50fc0 succeeds

  • merged

  • Doug Stull mentioned in commit 093807b1

    mentioned in commit 093807b1

  • added workflowstaging label and removed workflowcanary label

  • GitLab Release Tools Bot picked the changes into the branch 15-6-stable-ee-patch-2 with commit 628fb55b

    picked the changes into the branch 15-6-stable-ee-patch-2 with commit 628fb55b

  • Doug Stull mentioned in commit 628fb55b

    mentioned in commit 628fb55b

  • Automatically picked into !105804 (merged), will merge into 15-6-stable-ee ready for 15.6.2-ee.

  • mentioned in merge request !105804 (merged)

  • Please register or sign in to reply
    Loading