Hide marketing-related entries
Related to Not work " Hide marketing-related entries from... (#383738 - closed)
What does this MR do and why?
Show marketing related header entries only for SaaS
Screenshots or screen recordings
SaaS | NOT SaaS |
---|---|
![]() |
![]() |
How to set up and validate locally
- Setup gdk to simulate SaaS - https://docs.gitlab.com/ee/development/ee_features.html#simulate-a-saas-instance and restart GDK
- Visit
/help
path. Make sure marketing header is present - Setup gdk to NOT simulate SaaS - https://docs.gitlab.com/ee/development/ee_features.html#simulate-a-saas-instance and restart GDK
- Visit
/help
path. Make sure marketing header is NOT present
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.7
added UX automation:ux-missing-labels bugux devopsgrowth groupacquisition sectiongrowth typebug workflowin dev + 1 deleted label
assigned to @syarynovskyi
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
added Pick into 15.7 label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
3 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.06688abf: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1dbeb3f5: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Jessie Young (
@jessieay
) (UTC-8, 10 hours behind@syarynovskyi
)Jan Provaznik (
@jprovaznik
) (UTC+1, 1 hour behind@syarynovskyi
)frontend Fernando Arias (
@farias-gl
) (UTC-6, 8 hours behind@syarynovskyi
)Natalia Tepluhina (
@ntepluhina
) (UTC+1, 1 hour behind@syarynovskyi
)test for spec/features/*
Jessie Young (
@jessieay
) (UTC-8, 10 hours behind@syarynovskyi
)Maintainer review is optional for test for spec/features/*
UX Philip Joyce (
@philipjoyce
) (UTC+0, 2 hours behind@syarynovskyi
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded workflowin review label and removed workflowin dev label
- Resolved by Doug Stull
Hi @morefice Could you pls review backend/test and pass it the to
@dstull
?Hi @beckalippert Could you pls review UX ?
requested review from @morefice and @beckalippert
@beckalippert
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
removed review request for @beckalippert
added 391 commits
-
2b311e97...2c91658a - 389 commits from branch
master
- 56d10f59 - Hide marketing-related entries
- 2e080b98 - Move tests to the ee folder
-
2b311e97...2c91658a - 389 commits from branch
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 9b96bd36 and b52597fc
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.45 MB 3.45 MB - 0.0 % mainChunk 1.86 MB 1.86 MB - 0.0 %
Note: We do not have exact data for 9b96bd36. So we have used data from: 2332ae4d.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerThanks for creating this @syarynovskyi. In terms of the fix, I think we should keep the marketing header in the SM docs but we should honor the "disable marketing links" setting value.
- If an instance has selected to "disable marketing links" then we should not display marketing links in the nav
- If an instance has not selected to "disable marketing links" then we should display marketing links in the nav
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for b52597fcexpand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Govern | 6 | 0 | 0 | 1 | 6 | ❗ | | Plan | 33 | 0 | 1 | 0 | 34 | ✅ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Create | 18 | 0 | 1 | 0 | 19 | ✅ | | Manage | 19 | 0 | 3 | 2 | 22 | ❗ | | Verify | 11 | 0 | 1 | 0 | 12 | ✅ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 96 | 0 | 8 | 3 | 104 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
removed review request for @dstull
added 95 commits
-
2e080b98...7cc03e22 - 92 commits from branch
master
- 145c67d7 - Hide marketing-related entries
- 1dbeb3f5 - Move tests to the ee folder
- 06688abf - Use help_page_hide_commercial_content setting for header
Toggle commit list-
2e080b98...7cc03e22 - 92 commits from branch
- Resolved by Doug Stull
- Resolved by Doug Stull
Proposed hint text to provide more context to the user on what this setting actually controls
"“This setting will remove links the GitLab marketing site from the help documentation and navigation"
@phillipwells for your review
added Technical Writing UI text + 1 deleted label and removed 1 deleted label
added 1 commit
- b52597fc - Revert "Use help_page_hide_commercial_content setting for header"
requested review from @dstull
added severity4 label
added Pick into 15.6 label
removed Pick into 15.7 label
- Resolved by Doug Stull
- Resolved by Natalia Tepluhina
requested review from @vvempati
removed review request for @dstull
requested review from @ntepluhina
removed review request for @ntepluhina
- Resolved by Doug Stull
enabled an automatic merge when the pipeline for 8ca50fc0 succeeds
mentioned in commit 093807b1
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
picked the changes into the branch
15-6-stable-ee-patch-2
with commit 628fb55bmentioned in commit 628fb55b
Automatically picked into !105804 (merged), will merge into
15-6-stable-ee
ready for15.6.2-ee
.removed Pick into 15.6 label
mentioned in merge request !105804 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1748 (merged)