Add instance audit event for enabling admin mode
What does this MR do and why?
Related to #362101 (closed)
Screenshots or screen recordings
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @bdenkovych
- A deleted user
added backend label
1 Warning Please add a merge request subtype to this merge request. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/administration/audit_events.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Kassio Borges (
@kassio
) (UTC+0, 2 hours behind@bdenkovych
)Sean McGivern (
@smcgivern
) (UTC+0, 2 hours behind@bdenkovych
)~"group::authentication and authorization" Reviewer review is optional for ~"group::authentication and authorization" Smriti Garg (
@sgarg_gitlab
) (UTC+5.5, 3.5 hours ahead of@bdenkovych
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
added devopsmanage sectiondev labels
- Resolved by Bogdan Denkovych
@bdenkovych - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request.
added 1 commit
- b3bf929c - Draft: Add instance audit event for enabling admin mode
added 1 commit
- 5db2220a - Draft: Add instance audit event for enabling admin mode
added 1 commit
- 410224fe - Draft: Add instance audit event for enabling admin mode
- Resolved by George Koltsov
- Resolved by George Koltsov
added 1 commit
- 1e6dd2a2 - Draft: Add instance audit event for enabling admin mode
- Resolved by George Koltsov
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for d1c82d51expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Govern | 10 | 0 | 5 | 1 | 15 | ❗ | | Create | 28 | 0 | 1 | 1 | 29 | ❗ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Manage | 39 | 0 | 4 | 2 | 43 | ❗ | | Verify | 12 | 0 | 1 | 0 | 13 | ✅ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 147 | 0 | 15 | 4 | 162 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
- Resolved by George Koltsov
added 1 commit
- 137ebc3a - Draft: Add instance audit event for enabling admin mode
changed milestone to %15.7
removed workflowin dev label
removed quad-planningcomplete-no-action label
added 1 commit
- d5536698 - Add instance audit event for enabling admin mode
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- A deleted user
added documentation label
- Resolved by George Koltsov
@sgarg_gitlab Could you please review for ~"group::authentication and authorization" ?
requested review from @sgarg_gitlab
requested review from @eread
added 1 commit
- 1f5b335c - Add instance audit event for enabling admin mode
mentioned in merge request gitlab-com/www-gitlab-com!115396 (merged)
- Resolved by Bogdan Denkovych
@bdenkovych, please can you answer the question: Should this have a feature flag? to help with code review for the Authentication and Authorization group.This nudge was added by this triage-ops policy.
- Resolved by Bogdan Denkovych
added Technical Writing docsfeature labels
removed review request for @eread
- Resolved by Bogdan Denkovych
- Resolved by Bogdan Denkovych
Looks good to me @bdenkovych I am approving MR
@sgarg_gitlab
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
removed review request for @sgarg_gitlab
added 1 commit
- f667cc48 - Add instance audit event for enabling admin mode
requested review from @georgekoltsov
added 221 commits
-
f667cc48...a6ab7364 - 220 commits from branch
master
- d1c82d51 - Add instance audit event for enabling admin mode
-
f667cc48...a6ab7364 - 220 commits from branch
enabled an automatic merge when the pipeline for ee51161a succeeds
mentioned in commit f167b39c
mentioned in issue #362101 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1748 (merged)
mentioned in issue #282428 (closed)