Skip to content
Snippets Groups Projects

Globally enable the `:schema_linting` flag

Merged Denys Mishunov requested to merge 255919-enable-schema-linting-by-default into master
All threads resolved!

What does this MR do and why?

Globally enables the :schema_linting feature flag. The flag has been enabled globally on gitlab.com for 2 years and this MR is bringing the functionality to the self-managed instances by default.

Note: this MR does not do the cleanup or remove the flag just yet. It will be done in a separate MR.

Screenshots or screen recordings

No visual changes on gitlab.com should be available.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #255919 (closed)

Edited by Denys Mishunov

Merge request reports

Merged results pipeline #704292057 passed

Pipeline: GitLab

#704298106

    Pipeline: GitLab

    #704296382

      Merged results pipeline passed for 5ba4bbbe

      Test coverage 83.66% (11.55%) from 2 jobs
      Approval is optional

      Merged by Enrique AlcántaraEnrique Alcántara 2 years ago (Nov 24, 2022 2:57pm UTC)

      Merge details

      Pipeline #704419629 passed

      Pipeline passed for e97de548 on master

      Test coverage 72.11% (11.55%) from 2 jobs
      10 environments impacted.

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
    • 1 Warning
      :warning: Please add a merge request subtype to this merge request.

      If needed, you can retry the :repeat: danger-review job that generated this comment.

      Generated by :no_entry_sign: Danger

    • Allure report

      allure-report-publisher generated test report!

      e2e-package-and-test: :exclamation: test report for 3bdec4d8

      expand test summary
      +---------------------------------------------------------------------------+
      |                              suites summary                               |
      +----------------------+--------+--------+---------+-------+-------+--------+
      |                      | passed | failed | skipped | flaky | total | result |
      +----------------------+--------+--------+---------+-------+-------+--------+
      | Plan                 | 120    | 0      | 0       | 0     | 120   | ✅     |
      | Create               | 318    | 0      | 10      | 2     | 328   | ❗     |
      | Verify               | 90     | 0      | 16      | 0     | 106   | ✅     |
      | Manage               | 126    | 0      | 10      | 0     | 136   | ✅     |
      | Secure               | 12     | 0      | 4       | 2     | 16    | ❗     |
      | Package              | 0      | 0      | 6       | 0     | 6     | ➖     |
      | Govern               | 82     | 0      | 0       | 0     | 82    | ✅     |
      | Fulfillment          | 4      | 0      | 30      | 0     | 34    | ✅     |
      | Version sanity check | 0      | 0      | 2       | 2     | 2     | ➖     |
      | ModelOps             | 0      | 0      | 2       | 0     | 2     | ➖     |
      | Release              | 12     | 0      | 0       | 0     | 12    | ✅     |
      | Analytics            | 4      | 0      | 0       | 0     | 4     | ✅     |
      | Configure            | 0      | 0      | 6       | 0     | 6     | ➖     |
      | Monitor              | 2      | 0      | 0       | 0     | 2     | ✅     |
      +----------------------+--------+--------+---------+-------+-------+--------+
      | Total                | 770    | 0      | 86      | 6     | 856   | ❗     |
      +----------------------+--------+--------+---------+-------+-------+--------+
    • Denys Mishunov added 769 commits

      added 769 commits

      Compare with previous version

    • Denys Mishunov marked this merge request as ready

      marked this merge request as ready

    • Denys Mishunov changed title from {-Draft: Resolve "[Feature flag] Rollout of -}schema_linting" to {+Globally enable the :+}schema_linting flag

      changed title from {-Draft: Resolve "[Feature flag] Rollout of -}schema_linting" to {+Globally enable the :+}schema_linting flag

    • Denys Mishunov marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

      marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    • mentioned in issue #255919 (closed)

    • Author Maintainer

      @ealcantara could you please merge this? The MR turns of the :schema_linting flag by default for the self-hosted instances. The flag has been enabled globally on gitlab.com for 2 years.

    • Denys Mishunov requested review from @ealcantara

      requested review from @ealcantara

    • Enrique Alcántara approved this merge request

      approved this merge request

    • :wave: @ealcantara, thanks for approving this merge request.

      This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

      For more info, please refer to the following links:

    • 🤖 GitLab Bot 🤖 added 1 deleted label

      added 1 deleted label

    • Enrique Alcántara resolved all threads

      resolved all threads

    • Enrique Alcántara enabled an automatic merge when the pipeline for 5ba4bbbe succeeds

      enabled an automatic merge when the pipeline for 5ba4bbbe succeeds

    • Denys Mishunov resolved all threads

      resolved all threads

    • mentioned in commit e97de548

    • added workflowstaging label and removed workflowcanary label

    • Please register or sign in to reply
      Loading