Add issuable searches to search rate limit
What does this MR do and why?
Rate limits issuable searches so that we can re-enable searching made by anonymous users. This uses the existing search rate limit settings.
This is behind a feature flag rate_limit_issuable_searches
.
Note: I also considered rate limiting at the finder level, but I think there may be other places that use the finder but we don't want to include in the limit. For example, in the recent issues autocomplete finder, it adds a scope with a list of issue IDs so the searches here are fast and we do not need to limit them.
Related to #340836
How to set up and validate locally
- Enable
rate_limit_issuable_searches
- (Optional) Lower the search rate limit in Admin > Settings > Network > Search rate limits
- Load a page like
http://127.0.0.1:3000/dashboard/issues?scope=all&state=opened&search=test
many times to go over the limit - Get a 429 response
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.6
assigned to @engwan
added bugavailability typebug labels and removed typefeature label
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
- A deleted user
added backend feature flag labels
- Resolved by Heinrich Lee Yu
- Resolved by Heinrich Lee Yu
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Michał Wielich (
@michold
) (UTC+1, 7 hours behind@engwan
)Mehmet Emin Inac (
@minac
) (UTC+1, 7 hours behind@engwan
)UX Ali Ndlovu (
@andlovu
) (UTC+2, 6 hours behind@engwan
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger
added 246 commits
-
bcfc7ec8...295f7307 - 245 commits from branch
master
- 5f35abad - Add issuable searches to search rate limit
-
bcfc7ec8...295f7307 - 245 commits from branch
Allure report
allure-report-publisher
generated test report!e2e-package-and-test:
test report for 11dd7315expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Configure | 0 | 0 | 6 | 0 | 6 | ➖ | | Create | 318 | 0 | 10 | 0 | 328 | ✅ | | Govern | 84 | 0 | 2 | 0 | 86 | ✅ | | Fulfillment | 4 | 0 | 28 | 0 | 32 | ✅ | | Verify | 96 | 0 | 8 | 0 | 104 | ✅ | | Manage | 126 | 2 | 6 | 0 | 134 | ❌ | | Plan | 120 | 0 | 0 | 0 | 120 | ✅ | | Release | 12 | 0 | 0 | 0 | 12 | ✅ | | Secure | 14 | 0 | 2 | 6 | 16 | ❗ | | Analytics | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 6 | 0 | 6 | ➖ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | Monitor | 2 | 0 | 0 | 0 | 2 | ✅ | | ModelOps | 0 | 0 | 2 | 0 | 2 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 780 | 2 | 72 | 6 | 854 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 58447005expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Govern | 10 | 0 | 5 | 1 | 15 | ❗ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Manage | 39 | 0 | 4 | 2 | 43 | ❗ | | Verify | 12 | 0 | 1 | 0 | 13 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 147 | 0 | 15 | 3 | 162 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
added 298 commits
-
fca9ced8...01bdfba5 - 297 commits from branch
master
- 49658d5e - Add issuable searches to search rate limit
-
fca9ced8...01bdfba5 - 297 commits from branch
- Resolved by Heinrich Lee Yu
@engwan I couldn't find any information about what this MR is about and what I should be reviewing. Can you link the design issue if one exists?
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
@andlovu
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added 207 commits
-
49658d5e...6840ac9d - 206 commits from branch
master
- 752391f0 - Add issuable searches to search rate limit
-
49658d5e...6840ac9d - 206 commits from branch
changed milestone to %15.7
added missed:15.6 label
added 517 commits
-
22589065...53e61d9a - 516 commits from branch
master
- 24578d8f - Add issuable searches to search rate limit
-
22589065...53e61d9a - 516 commits from branch
added 3414 commits
-
58447005...3f4b5799 - 3413 commits from branch
master
- 4f61701f - Add issuable searches to search rate limit
-
58447005...3f4b5799 - 3413 commits from branch
added 1267 commits
-
5a8cfe3b...99c72fb2 - 1266 commits from branch
master
- 37d78689 - Add issuable searches to search rate limit
-
5a8cfe3b...99c72fb2 - 1266 commits from branch
- Resolved by Michael Kozono
- Resolved by Michael Kozono
- Resolved by Michael Kozono
- Resolved by Michael Kozono
@pedropombeiro can you review please?
requested review from @pedropombeiro
- Resolved by Pedro Pombeiro (OOO from Feb 17th-21st)
- Resolved by Pedro Pombeiro (OOO from Feb 17th-21st)
changed milestone to %15.8
added missed:15.7 label
removed workflowin dev label
requested review from @mkozono and removed review request for @pedropombeiro
- Resolved by Michael Kozono
@engwan LGTM! Since I don't have any blocking feedback, I opened a feature flag rollout issue, but please add it to the feature flag definition when you have a chance. Thank you!
enabled an automatic merge when the pipeline for 2ffd60ee succeeds
mentioned in commit 79ba45a4
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in merge request gitlab-com/www-gitlab-com!113988 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label