Replace default_value_for on ProjectFeature
Ref: #378997 (closed)
What does this MR do and why?
It replaces the usage of default_values_for
on ProjectFeature
model with a native Rails feature because that gem is unmaintained and it's blocking us from upgrading to Rails 7.
Used a similar technique implemented in !103787 (merged) to deal with existing records and making sure we set correctly their default value.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.6
added backend devopsverify grouppipeline security maintenancerefactor rails rails 7 sectionops typemaintenance + 1 deleted label
assigned to @morefice
1 Warning 51adb1aa: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Aman Luthra (
@aluthra2
) (UTC+5.5, 4.5 hours ahead of@morefice
)Charlie Ablett (
@cablett
) (UTC+13, 12 hours ahead of@morefice
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Useradded 18 commits
-
db4479b4...3ff322fb - 17 commits from branch
master
- c8073ae5 - Replace default_value_for on ProjectFeature
-
db4479b4...3ff322fb - 17 commits from branch
- Resolved by Igor Drozdov
- Resolved by Igor Drozdov
- Resolved by Max Orefice
requested review from @mbobin
removed review request for @mbobin
mentioned in issue #382707
added 382 commits
-
e08087fb...ca125dec - 381 commits from branch
master
- 2bd71083 - Replace default_value_for on ProjectFeature
-
e08087fb...ca125dec - 381 commits from branch
requested review from @mbobin
removed review request for @mbobin
changed milestone to %15.7