Skip to content
Snippets Groups Projects

Replace default_value_for on ProjectFeature

Merged Max Orefice requested to merge morefice/remove-default-values-5 into master

Ref: #378997 (closed)

What does this MR do and why?

It replaces the usage of default_values_for on ProjectFeature model with a native Rails feature because that gem is unmaintained and it's blocking us from upgrading to Rails 7.

Used a similar technique implemented in !103787 (merged) to deal with existing records and making sure we set correctly their default value.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Max Orefice

Merge request reports

Merged results pipeline #778596024 passed

Pipeline: GitLab

#778605796

    Merged results pipeline passed for ac46f399

    Test coverage 82.38% (15.56%) from 2 jobs

    Merged by Igor DrozdovIgor Drozdov 2 years ago (Feb 15, 2023 4:33pm UTC)

    Loading

    Pipeline #778727528 passed

    Pipeline passed for f036f93a on master

    Test coverage 66.83% (15.56%) from 2 jobs
    10 environments impacted.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Max Orefice
  • Max Orefice added 1 commit

    added 1 commit

    • 4458a27c - Replace default_value_for on ProjectFeature

    Compare with previous version

  • Max Orefice added 1 commit

    added 1 commit

    • 04a02dc0 - Replace default_value_for on ProjectFeature

    Compare with previous version

  • Marius Bobin
  • Max Orefice added 1 commit

    added 1 commit

    • e08087fb - Use default values to ProjectFeature

    Compare with previous version

  • Max Orefice requested review from @mbobin

    requested review from @mbobin

  • Max Orefice removed review request for @mbobin

    removed review request for @mbobin

  • Max Orefice mentioned in issue #382707

    mentioned in issue #382707

  • Max Orefice added 382 commits

    added 382 commits

    Compare with previous version

  • Max Orefice requested review from @mbobin

    requested review from @mbobin

  • Marius Bobin removed review request for @mbobin

    removed review request for @mbobin

  • 🤖 GitLab Bot 🤖 changed milestone to %15.7

    changed milestone to %15.7

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading