Skip to content

Update merge request loading error message

What does this MR do and why?

Creating merge_request_diffs asynchronously has been done in !100390 (merged) and this MR updates the error message to make it a bit more clear that they need to wait for a bit longer and retry again.

It is expected that users won't be seeing this error message very often unless merge_request_diff creation takes a while. This is to work around the occasional slowness that can happen with MRs from forked projects of large projects such as gitlab-org/gitlab

Related to #336657 (closed)

Screenshots or screen recordings

Kapture_2022-11-08_at_15.32.22

How to set up and validate locally

  1. Enable the async_merge_request_diff_creation
    Feature.enable(:async_merge_request_diff_creation)
  2. Stop sidekiq to mimic slow job
    gdk stop rails-background-jobs
  3. Make a commit via Web IDE or console and create an MR
  4. Click changes tab to see the error message
  5. Start sidekiq to mimic slow job
    gdk start rails-background-jobs
  6. Wait a little until the background job stats and processes the background job
  7. Check if diffs are generated by clicking changes tab -->

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #336657 (closed)

Edited by Sincheol (David) Kim

Merge request reports