Create merge_request_diff asynchronously
requested to merge 336657-activerecord-invalidforeignkey-pg-foreignkeyviolation-error-insert-or-update-on-table into master
What does this MR do and why?
We have some timeout issues when merge request is created against large projects like gitlab-org/gitlab from a fork.
This Mr backgrounds merge_request_diff creation to avoid gitaly timeouts during the MR creation.
It won't reload the page when the background job takes long so we may need some flash message for this.
Related: #336657 (closed)
How to set up and validate locally
- Enable the feature flag
Feature.enable(:async_merge_request_diff_creation) - Create an MR
- Observe diffs are populated as expected and no other errors appear
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #336657 (closed)
Edited by Sincheol (David) Kim