Bump Ruby version to 2.7.6
CI has been using 2.7.6 since gitlab-build-images!518 (merged). GDK is being updated in gitlab-development-kit!2781 (merged).
Related to https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/7243
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.6
assigned to @balasankarc
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer maintenanceworkflow / maintenancepipelines for CI, Danger Stanislav Dobrovolschii ( @sdobrovolschii
) (UTC+1, 4.5 hours behind@balasankarc
)David Dieulivol ( @ddieulivol
) (UTC+1, 4.5 hours behind@balasankarc
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger changed milestone to %15.7
added missed:15.6 label
@tkuah
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
Hmm, the pipeline created for this MR (only changes to
.ruby-version
) does not run anyrspec
jobsI would have expected a pipeline more like !68363 (merged). @tkuah @balasankarc @kerrizor We have: !105167 (merged).
@eread doesn't that then put us one release ahead of
gdk
?EOD it doesn't really matter, it's just a PITA to have to manually switch to the ruby that
gdk
expectsgitlab-org/gitlab
to be running under :/@kerrizor I think the plan is to have all the dependent projects merge (&9333 (closed)), then merge
gdk
with a clean.tool-versions
: gitlab-development-kit!2834 (comment 1186539111).@kerrizor there's this issue also: gitlab-development-kit#1595.
@nao.hashizume This seems to contradict the documentation written in https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/pipelines/index.md#exceptional-cases about the effect of ~"pipeline:run-full-rspec"
@tkuah @balasankarc @kerrizor We have: !105167 (merged).
We can close this MR in favor of that.
Since !105167 (merged) merged, this would be a downgrade so.. closing.
@jennli I understand that it is confusing. We can clarify that both condition need to be met in https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/development/pipelines/index.md#exceptional-cases:
- ~"pipeline:run-full-rspec" is applied
-
backend-patterns
is satisfied in the merge request
Edited by Nao Hashizume@nao.hashizume Thanks for the reply. I'm proposing a label change here, hopefully that clarifies the purpose of this label for team members
Edited by Jennifer LiWow, I did not notice there's pipeline:run-all-rspec and ~"pipeline:run-full-rspec"
@tkuah right? indeed misleading. I'm removing the latter one so hopefully that clarifies things
mentioned in issue #384086 (moved)
mentioned in issue gitlab-org/quality/quality-engineering/team-tasks#1557 (closed)