Fix discussions navigation on Changes page
What does this MR do and why?
Fixes Navigating back to Changes doesn't work if you ... (#371079 - closed)
This change ensures we will navigate to the first or last thread on the merge request Overview tab from the Changes tab when there are only threads not connected to MR code.
This change also fixes back\forward navigation when going from one page to another.
Screenshots or screen recordings
| Before | After |
|---|---|
| Screen_Recording_2022-11-02_at_18.26.43 | Screen_Recording_2022-11-02_at_18.25.27 |
How to set up and validate locally
- Open an MR with discussion threads only for the MR itself but not the MR code
- Open Changes tab
- Navigate through threads (using this interface:
)
You should be redirected to Overview tab and the first\last thread should be in view. Also clicking on Back button in your browser should bring you back to Changes page.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Stanislav Lashmanov