Skip to content
Snippets Groups Projects

Added a UI to create timelogs

Merged Marco Zille requested to merge zillemarco/gitlab:zillemarco-add-timelog-ui into master
All threads resolved!

What does this MR do and why?

Related to &8429.

This MR adds the UI to allow users to create a time entry without using the quick action :slight_smile:

The button to open the form is only visible for Reporter+ users since guests cannot create time entries.

The form also supports quick submit to quickly create a time entry with:

  • Ctrl + Enter or Cmd + Enter when the focus is on the Summary text area field
  • Simply Enter when focus is on the Time spent field.

Screenshots or screen recordings

Create a time entry

Registrazione_schermo_2022-11-25_alle_22.25.38

Create a time entry for a specific date

Registrazione_schermo_2022-11-25_alle_22.27.55

Display of error

Ipsa_rerum_nostrum_et_neque_eaque_sed_laboriosam_ipsum_omnis_sint.__10____Issues___Flightjs___Flight___GitLab-Personale-_Microsoft__Edge_2022-11-29_09-47-35

How to set up and validate locally

  1. Go to an issuable page, either Issue or Merge Request
  2. Use the + button on the Time tracking section of the sidebar to create a time entry

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Marco Zille

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • changed milestone to %15.7

  • Alan (Maciej) Paruszewski
  • Marco Zille mentioned in issue #383999

    mentioned in issue #383999

  • Marco Zille added 1 commit

    added 1 commit

    • 9ca2b8d8 - Applied suggestions from review

    Compare with previous version

  • Marco Zille changed the description

    changed the description

  • Marcin Sedlak-Jakubowski approved this merge request

    approved this merge request

  • 🤖 GitLab Bot 🤖 added 1 deleted label

    added 1 deleted label

  • removed review request for @msedlakjakubowski

  • Nick Leonard removed review request for @nickleonard

    removed review request for @nickleonard

  • Nick Leonard approved this merge request

    approved this merge request

  • Alan (Maciej) Paruszewski approved this merge request

    approved this merge request

  • Alan (Maciej) Paruszewski requested review from @DylanGriffith and removed review request for @mparuszewski

    requested review from @DylanGriffith and removed review request for @mparuszewski

  • Marco Zille added 923 commits

    added 923 commits

    Compare with previous version

  • Dylan Griffith approved this merge request

    approved this merge request

  • Dylan Griffith removed review request for @DylanGriffith

    removed review request for @DylanGriffith

    • Resolved by Andrei Zubov

      [nitpick - UX, non-blocking] when keyboard navigating with tabs through the form there's an extra tab press required to tab out from the date picker to summary field. I'm not sure if anything could be done here, but if that could be improved that'd be great! Totally non-blocking, however, as the form keyboard navigation is great apart from that tiny thing.

  • Andrei Zubov approved this merge request

    approved this merge request

  • Andrei Zubov requested review from @jannik_lehmann and removed review request for @andrei.zubov

    requested review from @jannik_lehmann and removed review request for @andrei.zubov

  • Marco Zille added 1 commit

    added 1 commit

    • 0e5182f0 - Applied suggestion from review

    Compare with previous version

    • Author Developer
      Resolved by Jannik Lehmann

      @nickleonard another small thing :slight_smile:

      When I joined the pairing session with @jannik_lehmann, @pslaughter and @andrei.zubov, they rightfully pointed out that while we are introducing new functionalities, we are losing some others, specifically:

      1. We are removing the help button from the widget on the sidebar so we now don't have any reference to the /estimate quick action, which would be useful until we also create the UI for that
      2. We now have lost the ability to set the time part of "spent at" of a time entry, mostly because we don't currently have a time picker control on the GitLab UI (right?), so here too having a reference to the quick actions would be beneficial

      So, WDYT about adding a text inside the modal to say something along the lines of

      View the full documentation on how time tracking works (e.g. setting estimated time) on this page.

      ? :slight_smile:

      Bias for action I'm gonna implement that, we can always go back if needed :slight_smile:

  • added workflowin dev label and removed workflowin review label

  • mentioned in issue gitlab-ui#2097

  • Jannik Lehmann removed review request for @jannik_lehmann

    removed review request for @jannik_lehmann

  • Marco Zille added 1 commit

    added 1 commit

    • 84ae713b - Applied suggestions from review

    Compare with previous version

  • Marco Zille added 1 commit

    added 1 commit

    • 2d805ed3 - Fixed failing specs and jobs

    Compare with previous version

  • Author Developer

    Hi @DylanGriffith :wave: :slight_smile: You already approved this MR changes to the backend but I since then made some additional changes I was requested (coming from the frontend) :slight_smile:

    Would you mind giving it another look? :pray: Thanks a lot! :bow: :slight_smile:

    @gitlab-bot ready @DylanGriffith

  • requested review from @DylanGriffith

  • @DylanGriffith, this Community contribution is ready for review.

    • Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
    • Add the workflowin dev label if the merge request needs action from the author. This message was generated automatically. You're welcome to improve it.
  • Dylan Griffith approved this merge request

    approved this merge request

  • Dylan Griffith removed review request for @DylanGriffith

    removed review request for @DylanGriffith

  • Hi @DylanGriffith :wave:

    It looks like the wrong workflow label is set. Should the workflowin dev label be applied, or the merge request passed to a reviewer?

    @zillemarco you are welcome to relabel by commenting @gitlab-bot label ~"workflow::in dev" for example.

  • requested review from @DylanGriffith

  • Dylan Griffith removed review request for @DylanGriffith

    removed review request for @DylanGriffith

  • requested review from @msedlakjakubowski

  • @msedlakjakubowski, this Community contribution is ready for review.

    • Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
    • Add the workflowin dev label if the merge request needs action from the author. This message was generated automatically. You're welcome to improve it.
  • added twfinished label and removed twdoing label

  • removed review request for @msedlakjakubowski

  • Hi @msedlakjakubowski :wave:

    It looks like the wrong workflow label is set. Should the workflowin dev label be applied, or the merge request passed to a reviewer?

    @zillemarco you are welcome to relabel by commenting @gitlab-bot label ~"workflow::in dev" for example.

  • requested review from @msedlakjakubowski

  • removed review request for @msedlakjakubowski

  • Marco Zille added 1 commit

    added 1 commit

    • 038dfbdd - Applied suggestion from review

    Compare with previous version

  • Hi @msedlakjakubowski :wave:

    It looks like the wrong workflow label is set. Should the workflowin dev label be applied, or the merge request passed to a reviewer?

    @zillemarco you are welcome to relabel by commenting @gitlab-bot label ~"workflow::in dev" for example.

  • requested review from @msedlakjakubowski

  • requested review from @jannik_lehmann

  • @msedlakjakubowski @jannik_lehmann, this Community contribution is ready for review.

    • Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
    • Add the workflowin dev label if the merge request needs action from the author. This message was generated automatically. You're welcome to improve it.
  • removed review request for @msedlakjakubowski

  • A deleted user added backend frontend labels

    added backend frontend labels

  • 4 Warnings
    :warning: This MR changes code in ee/, but its Changelog commit is missing the EE: true trailer. Consider adding it to your Changelog commits.
    :warning: This merge request is quite big (818 lines changed), please consider splitting it into multiple merge requests.
    :warning: be684d98: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
    :warning: 81798a4a: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
    1 Message
    :book: This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

    Documentation review

    The following files require a review from a technical writer:

    The review does not need to block merging this merge request. See the:

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Kassio Borges current availability (@kassio) (UTC+0) Tetiana Chupryna current availability (@brytannia) (UTC+1)
    frontend Deepika Guliani current availability (@deepika.guliani) (UTC+5.5) Jose Ivan Vargas current availability (@jivanvl) (UTC-6)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits c7888a0e and 45abbaf2

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.45 MB 3.46 MB +3.2 KB 0.1 %
    mainChunk 1.86 MB 1.86 MB - 0.0 %

    :fearful: Significant Growth: 10

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.dashboard.milestones.show 616.6 KB 757.28 KB +140.68 KB 22.8 %
    pages.projects.branches.index 1.03 MB 1.14 MB +109.7 KB 10.4 %
    pages.groups.milestones.edit 1.67 MB 1.77 MB +100.6 KB 5.9 %
    pages.groups.milestones.new 1.67 MB 1.77 MB +100.6 KB 5.9 %
    pages.projects.milestones.edit 1.78 MB 1.87 MB +100.6 KB 5.5 %
    pages.projects.milestones.index 1.78 MB 1.87 MB +100.6 KB 5.5 %
    pages.projects.milestones.new 1.78 MB 1.87 MB +100.6 KB 5.5 %
    pages.groups.observability.dashboards 105.65 KB 117.75 KB +12.1 KB 11.5 %
    pages.groups.observability.explore 105.65 KB 117.75 KB +12.1 KB 11.5 %
    pages.groups.observability.manage 105.65 KB 117.75 KB +12.1 KB 11.5 %

    :tada: Significant Reduction: 5

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.projects.settings.ci_cd.show 2.93 MB 2.8 MB -132.91 KB -4.4 %
    pages.projects.licenses.index 2.24 MB 2.12 MB -123.73 KB -5.4 %
    pages.projects.settings.merge_requests 2.19 MB 2.14 MB -52.11 KB -2.3 %
    pages.projects.settings.repository.create_deploy_token 1.39 MB 1.33 MB -51.32 KB -3.6 %
    pages.projects.settings.repository.show 1.39 MB 1.33 MB -51.32 KB -3.6 %

    Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

    Please consider pinging someone from the FE Foundations (@leipert, @markrian, @mikegreiling, @ohoral or @pgascouvaillancourt) for review, if you are unsure about the size increase.

    Note: We do not have exact data for c7888a0e. So we have used data from: f257619d.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Jannik Lehmann mentioned in issue #385182

    mentioned in issue #385182

    • Resolved by Marco Zille

      @zillemarco Thanks for this great contribution, I reviewed the MR and found a small handful of minor improvements for you to check out.

      Very much looking forward to see this merged, since this is almost there.

      Thanks for your efforts! With that over to you :ping_pong:

  • Jannik Lehmann removed review request for @jannik_lehmann

    removed review request for @jannik_lehmann

  • Hi @jannik_lehmann :wave:

    It looks like the wrong workflow label is set. Should the workflowin dev label be applied, or the merge request passed to a reviewer?

    @zillemarco you are welcome to relabel by commenting @gitlab-bot label ~"workflow::in dev" for example.

  • requested review from @jannik_lehmann

  • added workflowin dev label and removed workflowready for review label

  • Lee Tickett removed review request for @jannik_lehmann

    removed review request for @jannik_lehmann

  • Marco Zille added 1 commit

    added 1 commit

    • 15963792 - Applied suggestions from review

    Compare with previous version

  • Marco Zille added 1731 commits

    added 1731 commits

    Compare with previous version

  • requested review from @jannik_lehmann

  • Jannik Lehmann approved this merge request

    approved this merge request

  • Jannik Lehmann resolved all threads

    resolved all threads

  • Jannik Lehmann enabled an automatic merge when the pipeline for 4926e79d succeeds

    enabled an automatic merge when the pipeline for 4926e79d succeeds

  • Allure report

    allure-report-publisher generated test report!

    e2e-review-qa: :exclamation: test report for 45abbaf2

    expand test summary
    +-----------------------------------------------------------------------------------------+
    |                                     suites summary                                      |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    |                                    | passed | failed | skipped | flaky | total | result |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Create                             | 28     | 0      | 1       | 0     | 29    | ✅     |
    | Manage                             | 39     | 0      | 4       | 2     | 43    | ❗     |
    | Plan                               | 49     | 0      | 1       | 0     | 50    | ✅     |
    | Verify                             | 12     | 0      | 1       | 0     | 13    | ✅     |
    | Govern                             | 13     | 0      | 5       | 1     | 18    | ❗     |
    | Version sanity check               | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Package                            | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Feature flag handler sanity checks | 9      | 0      | 0       | 0     | 9     | ✅     |
    | Configure                          | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Total                              | 150    | 0      | 15      | 3     | 165   | ❗     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
  • Jannik Lehmann mentioned in commit 5903ce0f

    mentioned in commit 5903ce0f

  • Marco Zille mentioned in merge request !106488 (merged)

    mentioned in merge request !106488 (merged)

  • added workflowstaging label and removed workflowcanary label

  • Marco Zille mentioned in epic &8429

    mentioned in epic &8429

  • Jannik Lehmann added 1h of time spent

    added 1h of time spent

  • Jannik Lehmann added 1m of time spent

    added 1m of time spent

  • Jannik Lehmann added 1m of time spent

    added 1m of time spent

  • Jannik Lehmann added 1h of time spent

    added 1h of time spent

  • Please register or sign in to reply
    Loading