Added a UI to create timelogs
What does this MR do and why?
Related to &8429.
This MR adds the UI to allow users to create a time entry without using the quick action
The button to open the form is only visible for Reporter+ users since guests cannot create time entries.
The form also supports quick submit to quickly create a time entry with:
-
Ctrl + Enter
orCmd + Enter
when the focus is on theSummary
text area field - Simply
Enter
when focus is on theTime spent
field.
Screenshots or screen recordings
Create a time entry
Registrazione_schermo_2022-11-25_alle_22.25.38
Create a time entry for a specific date
Registrazione_schermo_2022-11-25_alle_22.27.55
Display of error
How to set up and validate locally
- Go to an issuable page, either Issue or Merge Request
- Use the
+
button on theTime tracking
section of the sidebar to create a time entry
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added Leading Organization label
Hey @zillemarco!
Thank you for your contribution to GitLab. Please refer to the contribution flow documentation for a quick overview of the process, and the merge request (MR) guidelines for the detailed process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help moving the MR forward, feel free to post
@gitlab-bot help
. Read more on how to get help.To enable automated checks on your MR, please configure Danger for your fork.
You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @zillemarco
- Resolved by Jannik Lehmann
Hi @nickleonard
Finally I was able to move on with the UI to create timelogs and I would love to have some feedback from you before moving onCould you please have a look when you have some spare time?
Thanks a lot!I'm not using the
@gitlab-bot ready
command to set you as reviewer because this is still far from ready
4 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.This merge request is quite big (818 lines changed), please consider splitting it into multiple merge requests. be684d98: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 81798a4a: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/api/graphql/reference/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Kassio Borges (
@kassio
) (UTC+0)Tetiana Chupryna (
@brytannia
) (UTC+1)frontend Deepika Guliani (
@deepika.guliani
) (UTC+5.5)Jose Ivan Vargas (
@jivanvl
) (UTC-6)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Marco Zille-
mentioned in issue gitlab-org/quality/triage-reports#9593 (closed)
added featureaddition time tracking labels
added typefeature label
added groupproject management label
added devopsplan sectiondev labels
requested review from @nickleonard
removed review request for @nickleonard
- Resolved by Jannik Lehmann
I took a quick look and think this looks great as a first iteration. There are a number of things I'd love to discuss/suggest/attempt in the coming iterations, but only one thing I feel strongly about for the minimum viable.
That one thing is to leave the "spent at" box empty by default (possibly with a placeholder). If the box is left blank the server will default to "now".
I guess the alternative would be to set the default value to the current date AND TIME rather than just the current date?
Thanks a mill for working on this @zillemarco - I can't wait to see the future for time tracking
@zillemarco, it seems we're waiting on an action from you for approximately two weeks.
- Do you still have capacity to work on this? If not, you might want to close this MR and/or ask someone to take over.
- Do you need help in getting it ready? At any time, you can ask for help with
@gitlab-bot help
. - If you're actually ready for a review, you can post
@gitlab-bot ready
.
added automation:author-reminded label
added 3940 commits
-
d58416a4...3199d0a3 - 3938 commits from branch
gitlab-org:master
- 670a14c2 - Added a UI to create timelogs
- 852504c5 - Applied some suggestions
-
d58416a4...3199d0a3 - 3938 commits from branch
added 2 commits
mentioned in issue #382727
added 1107 commits
Toggle commit listadded 1034 commits
-
dee39207...214e0f29 - 1033 commits from branch
gitlab-org:master
- 5c7c41b5 - Added a UI to create timelogs
-
dee39207...214e0f29 - 1033 commits from branch
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Dylan Griffith
@nickleonard I was finally able to finish this off and it's ready for a full review
Hi @mparuszewski
Could you have a look at the backend changes? Thanks a lot! FYI, the changed GraphQL mutation was not used anywhere up to now (I introduced it a few months back) and also it wouldn't have worked anyway if someone provided the time so I don't think we'll need to split it into a separate MRHi @andrei.zubov
Could you have a look at the frontend changes? Thanks a lot!
added workflowready for review label and removed workflowin dev label
requested review from @nickleonard, @mparuszewski, and @andrei.zubov
- Resolved by Dylan Griffith
Hi
@ashrafkhamis
! Please review this documentation merge request. This message was generated automatically. You're welcome to improve it.
added documentation twtriaged labels
requested review from @ashrafkhamis
@mparuszewski
@nickleonard
@ashrafkhamis
@andrei.zubov
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author. This message was generated automatically. You're welcome to improve it.
removed automation:author-reminded label
requested review from @msedlakjakubowski and removed review request for @ashrafkhamis
- Resolved by Marco Zille
- Resolved by Marco Zille
- Resolved by Marco Zille
changed milestone to %15.7
added UI text label
added Technical Writing docsfeature twdoing workflowin review labels and removed twtriaged workflowready for review labels
- Resolved by Marco Zille
mentioned in issue #383999
- Resolved by Jannik Lehmann
@msedlakjakubowski
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
removed review request for @msedlakjakubowski
removed review request for @nickleonard
requested review from @DylanGriffith and removed review request for @mparuszewski
added 923 commits
-
9ca2b8d8...6bc8125f - 919 commits from branch
gitlab-org:master
- d4c8c803 - Added a UI to create timelogs
- 77fd6b64 - Fixed broken tests
- 3c09bc35 - Applied suggestions from review
- 2b540922 - Fixed conflicts with master
Toggle commit list-
9ca2b8d8...6bc8125f - 919 commits from branch
removed review request for @DylanGriffith
- Resolved by Andrei Zubov
Hi @andrei.zubov
Just pinging to make sure this is on your tracks Do you have capacity to review or would you prefer to assign it to someone else?Thanks a lot!
- Resolved by Andrei Zubov
- Resolved by Andrei Zubov
[nitpick - UX, non-blocking] when keyboard navigating with tabs through the form there's an extra tab press required to tab out from the date picker to summary field. I'm not sure if anything could be done here, but if that could be improved that'd be great! Totally non-blocking, however, as the form keyboard navigation is great apart from that tiny thing.
- Resolved by Jannik Lehmann
- Resolved by Jannik Lehmann
Thanks @zillemarco for your great contribution! The feature looks really good and smooth! I've left a few non-blocking comments and pass this MR further for the maintainer review!
@jannik_lehmann could you please help with the maintainer review?
requested review from @jannik_lehmann and removed review request for @andrei.zubov
- Resolved by Jannik Lehmann
@nickleonard another small thing
When I joined the pairing session with
@jannik_lehmann
,@pslaughter
and@andrei.zubov
, they rightfully pointed out that while we are introducing new functionalities, we are losing some others, specifically:- We are removing the help button from the widget on the sidebar so we now don't have any reference to the
/estimate
quick action, which would be useful until we also create the UI for that - We now have lost the ability to set the time part of "spent at" of a time entry, mostly because we don't currently have a time picker control on the GitLab UI (right?), so here too having a reference to the quick actions would be beneficial
So, WDYT about adding a text inside the modal to say something along the lines of
View the full documentation on how time tracking works (e.g. setting estimated time) on this page.
?
Bias for action I'm gonna implement that, we can always go back if needed
- We are removing the help button from the widget on the sidebar so we now don't have any reference to the
added workflowin dev label and removed workflowin review label
mentioned in issue gitlab-ui#2097
removed review request for @jannik_lehmann
Hi @DylanGriffith
You already approved this MR changes to the backend but I since then made some additional changes I was requested (coming from the frontend)Would you mind giving it another look?
Thanks a lot!@gitlab-bot ready @DylanGriffith
added workflowready for review label and removed workflowin dev label
requested review from @DylanGriffith
@DylanGriffith
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author. This message was generated automatically. You're welcome to improve it.
- Resolved by Dylan Griffith
@zillemarco this still looks good to me but I won't merge as it looks like it has unresolved threads and I don't think it has frontend maintainer approval yet.
removed review request for @DylanGriffith
It looks like the wrong workflow label is set. Should the workflowin dev label be applied, or the merge request passed to a reviewer?
@zillemarco you are welcome to relabel by commenting
@gitlab-bot label ~"workflow::in dev"
for example.requested review from @DylanGriffith
added workflowin dev label and removed workflowready for review label
removed review request for @DylanGriffith
added workflowready for review label and removed workflowin dev label
requested review from @msedlakjakubowski
@msedlakjakubowski
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author. This message was generated automatically. You're welcome to improve it.
added twfinished label and removed twdoing label
removed review request for @msedlakjakubowski
It looks like the wrong workflow label is set. Should the workflowin dev label be applied, or the merge request passed to a reviewer?
@zillemarco you are welcome to relabel by commenting
@gitlab-bot label ~"workflow::in dev"
for example.requested review from @msedlakjakubowski
added workflowin review label and removed workflowready for review label
removed review request for @msedlakjakubowski
It looks like the wrong workflow label is set. Should the workflowin dev label be applied, or the merge request passed to a reviewer?
@zillemarco you are welcome to relabel by commenting
@gitlab-bot label ~"workflow::in dev"
for example.requested review from @msedlakjakubowski
added workflowready for review label and removed workflowin review label
requested review from @jannik_lehmann
@msedlakjakubowski
@jannik_lehmann
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author. This message was generated automatically. You're welcome to improve it.
removed review request for @msedlakjakubowski
4 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.This merge request is quite big (818 lines changed), please consider splitting it into multiple merge requests. be684d98: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 81798a4a: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/api/graphql/reference/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Kassio Borges (
@kassio
) (UTC+0)Tetiana Chupryna (
@brytannia
) (UTC+1)frontend Deepika Guliani (
@deepika.guliani
) (UTC+5.5)Jose Ivan Vargas (
@jivanvl
) (UTC-6)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits c7888a0e and 45abbaf2
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.45 MB 3.46 MB +3.2 KB 0.1 % mainChunk 1.86 MB 1.86 MB - 0.0 % Significant Growth: 10Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.dashboard.milestones.show 616.6 KB 757.28 KB +140.68 KB 22.8 % pages.projects.branches.index 1.03 MB 1.14 MB +109.7 KB 10.4 % pages.groups.milestones.edit 1.67 MB 1.77 MB +100.6 KB 5.9 % pages.groups.milestones.new 1.67 MB 1.77 MB +100.6 KB 5.9 % pages.projects.milestones.edit 1.78 MB 1.87 MB +100.6 KB 5.5 % pages.projects.milestones.index 1.78 MB 1.87 MB +100.6 KB 5.5 % pages.projects.milestones.new 1.78 MB 1.87 MB +100.6 KB 5.5 % pages.groups.observability.dashboards 105.65 KB 117.75 KB +12.1 KB 11.5 % pages.groups.observability.explore 105.65 KB 117.75 KB +12.1 KB 11.5 % pages.groups.observability.manage 105.65 KB 117.75 KB +12.1 KB 11.5 % Significant Reduction: 5Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.settings.ci_cd.show 2.93 MB 2.8 MB -132.91 KB -4.4 % pages.projects.licenses.index 2.24 MB 2.12 MB -123.73 KB -5.4 % pages.projects.settings.merge_requests 2.19 MB 2.14 MB -52.11 KB -2.3 % pages.projects.settings.repository.create_deploy_token 1.39 MB 1.33 MB -51.32 KB -3.6 % pages.projects.settings.repository.show 1.39 MB 1.33 MB -51.32 KB -3.6 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@mikegreiling
,@ohoral
or@pgascouvaillancourt
) for review, if you are unsure about the size increase.Note: We do not have exact data for c7888a0e. So we have used data from: f257619d.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Jannik Lehmann
- Resolved by Jannik Lehmann
- Resolved by Jannik Lehmann
- Resolved by Jannik Lehmann
mentioned in issue #385182
- Resolved by Marco Zille
@zillemarco Thanks for this great contribution, I reviewed the MR and found a small handful of minor improvements for you to check out.
Very much looking forward to see this merged, since this is almost there.
Thanks for your efforts! With that over to you
removed review request for @jannik_lehmann
It looks like the wrong workflow label is set. Should the workflowin dev label be applied, or the merge request passed to a reviewer?
@zillemarco you are welcome to relabel by commenting
@gitlab-bot label ~"workflow::in dev"
for example.requested review from @jannik_lehmann
added workflowin dev label and removed workflowready for review label
removed review request for @jannik_lehmann
added 1731 commits
-
15963792...a9195887 - 1722 commits from branch
gitlab-org:master
- 38333620 - Added a UI to create timelogs
- 81798a4a - Fixed broken tests
- 9cba8494 - Applied suggestions from review
- 2293a048 - Fixed conflicts with master
- c39c2043 - Applied suggestion from review
- be684d98 - Applied suggestions from review
- 269cb873 - Fixed failing specs and jobs
- 124499c5 - Applied suggestion from review
- 45abbaf2 - Applied suggestions from review
Toggle commit list-
15963792...a9195887 - 1722 commits from branch
requested review from @jannik_lehmann
enabled an automatic merge when the pipeline for 4926e79d succeeds
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 45abbaf2expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Manage | 39 | 0 | 4 | 2 | 43 | ❗ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Verify | 12 | 0 | 1 | 0 | 13 | ✅ | | Govern | 13 | 0 | 5 | 1 | 18 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 150 | 0 | 15 | 3 | 165 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
mentioned in commit 5903ce0f
added workflowstaging-canary label and removed workflowin dev label
mentioned in merge request !106488 (merged)
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in epic &8429
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1748 (merged)
added pipeline:mr-approved label