Skip to content
Snippets Groups Projects

Remove canRenew condition from billing page

Merged Diana Zubova requested to merge dz/363439-remove-unnecessary-condition-on-billing into master

What does this MR do and why?

Let the GraphQL call handle the Renew button visibility, we already account for subscription end date and trials on backend side when computing the inRenewalPeriod value on the API side.

The changes are targeting EDU/OSS subscriptions as they have a longer period for renewal (3 months vs 15 days in all the other cases)

Related to #363439 (closed) && #378283 (closed)

Screenshots or screen recordings

Before After
Screenshot_2022-10-18_at_11.58.28 Screenshot_2022-10-18_at_14.27.08

How to set up and validate locally

Prerequisites: GitLab and CustomersDot connected, Zuora account

  1. (Zuora) Create an EDU/OSS SaaS subscription in Zuora with the term date in 2 months
  2. (CustomersDot) Assign this subscription to a group
  3. (GitLab) Navigate to that group billing page (http://localhost:3000/groups/test-group/-/billings)
  4. (GitLab) Check if the visibility of the buttons set correctly

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Diana Zubova

Merge request reports

Merged results pipeline #671875196 passed

Pipeline: GitLab

#671878243

    Pipeline: GitLab

    #671898585

      Merged results pipeline passed for 59f904d4

      Test coverage 48.02% from 2 jobs

      Merged by Natalia TepluhinaNatalia Tepluhina 2 years ago (Oct 20, 2022 8:49am UTC)

      Loading

      Pipeline #671948620 passed

      Pipeline passed for c5f33a77 on master

      Test coverage 71.63% from 2 jobs
      10 environments impacted.

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Please register or sign in to reply
      Loading