Skip to content
Snippets Groups Projects

Remove canRenew condition from billing page

Merged Diana Zubova requested to merge dz/363439-remove-unnecessary-condition-on-billing into master
All threads resolved!

What does this MR do and why?

Let the GraphQL call handle the Renew button visibility, we already account for subscription end date and trials on backend side when computing the inRenewalPeriod value on the API side.

The changes are targeting EDU/OSS subscriptions as they have a longer period for renewal (3 months vs 15 days in all the other cases)

Related to #363439 (closed) && #378283 (closed)

Screenshots or screen recordings

Before After
Screenshot_2022-10-18_at_11.58.28 Screenshot_2022-10-18_at_14.27.08

How to set up and validate locally

Prerequisites: GitLab and CustomersDot connected, Zuora account

  1. (Zuora) Create an EDU/OSS SaaS subscription in Zuora with the term date in 2 months
  2. (CustomersDot) Assign this subscription to a group
  3. (GitLab) Navigate to that group billing page (http://localhost:3000/groups/test-group/-/billings)
  4. (GitLab) Check if the visibility of the buttons set correctly

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Diana Zubova

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ammar Alakkad approved this merge request

    approved this merge request

  • Ammar Alakkad requested review from @ntepluhina and removed review request for @aalakkad

    requested review from @ntepluhina and removed review request for @aalakkad

  • Natalia Tepluhina approved this merge request

    approved this merge request

  • Natalia Tepluhina resolved all threads

    resolved all threads

  • Natalia Tepluhina enabled an automatic merge when the pipeline for 5bcb7108 succeeds

    enabled an automatic merge when the pipeline for 5bcb7108 succeeds

  • Diana Zubova aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Diana Zubova added 450 commits

    added 450 commits

    Compare with previous version

  • Natalia Tepluhina enabled an automatic merge when the pipeline for 59f904d4 succeeds

    enabled an automatic merge when the pipeline for 59f904d4 succeeds

  • Diana Zubova resolved all threads

    resolved all threads

  • mentioned in commit c5f33a77

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading