Skip to content

Bump marginalia gem to 1.11.1

Aleksei Lipniagov requested to merge 378178-bump-marginalia-to-1-11-1 into master

What does this MR do and why?

Update marginalia from 1.10.0 to 1.11.1

Starting from 1.11.0, testing against Ruby 3 in CI (GH Actions) was added: https://github.com/basecamp/marginalia/commit/8c89d7b2cfa0eff095b699ea023de2a6447950af

It is reasonable to upgrade to the version tested under Ruby 3. Compared to 1.11.0, 1.11.1 (the latest) fixes warnings related to ruby2_keywords (https://github.com/basecamp/marginalia/commit/54518f38b1ccac6594e5b855fa42a4ce041bb8ad), so it's worth including it too.

How to set up and validate locally

Pull this branch.
Make sure the listed version of marginalia is installed for you locally.
Restart the server.

In tail -f log/development.log, you should see a similar format:

   (0.2ms)  SELECT "ci_project_mirrors"."project_id", "ci_project_mirrors"."namespace_id" FROM "ci_project_mirrors" WHERE "ci_project_mirrors"."project_id" >= 1 AND "ci_project_mirrors"."project_id" < 501 ORDER BY "ci_project_mirrors"."project_id" ASC /*application:sidekiq,correlation_id:b81f6fcba02fb809b0e58c24b80987e9,jid:283bc6d4c7216cf522ab70c4,endpoint_id:Database::CiProjectMirrorsConsistencyCheckWorker,db_config_name:ci,line:/lib/gitlab/database/consistency_checker.rb:38:in `block in execute'*/
  ↳ lib/gitlab/database/consistency_checker.rb:38:in `block in execute'
  CACHE  (0.0ms)  SELECT MIN("projects"."id") FROM "projects"
  ↳ lib/gitlab/database/consistency_checker.rb:106:in `min_id'

These added by marginalia.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #378178 (closed)

Edited by Aleksei Lipniagov

Merge request reports