Add `incident declare` slash command with base logic
What does this MR do and why?
Adds base code for incident declare
slash command.
This change is behind a feature flag and is disabled by default.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
- Follow the steps mentioned in https://gitlab.com/gitlab-org/manage/integrations/team/-/blob/main/integrations/slack.md for setting up a slack workspace to test the command.
- Enable the FF per user to see it on the list of commands if that specific user sends a command.
- Try using
/dev-gitlab help
to check the list of commands. If FF is disabled, it does not show/dev-gitlab incident declare
in the list of commands. If the FF is enabled, then it shows up. - Try using
/dev-gitlab incident declare
. If FF is disabled, it shows that the command is invalid, if FF is enabled, it showsIt works!
in the slack message.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #344856 (closed)
Merge request reports
Activity
changed milestone to %15.5
assigned to @rkadam3
- A deleted user
added backend label
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Hordur Freyr Yngvason (
@hfyngvason
) (UTC-5, 10.5 hours behind@rkadam3
)Doug Stull (
@dstull
) (UTC-5, 10.5 hours behind@rkadam3
)UX Daniel Mora (
@dmoraBerlin
) (UTC+1, 4.5 hours behind@rkadam3
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for b423d11fexpand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Manage | 43 | 0 | 3 | 8 | 46 | ❗ | | Govern | 10 | 0 | 5 | 0 | 15 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Verify | 12 | 0 | 1 | 0 | 13 | ✅ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 151 | 0 | 14 | 8 | 165 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for b423d11fexpand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Manage | 136 | 0 | 26 | 4 | 162 | ❗ | | Create | 318 | 0 | 10 | 2 | 328 | ❗ | | Plan | 120 | 0 | 0 | 0 | 120 | ✅ | | Govern | 82 | 0 | 0 | 0 | 82 | ✅ | | Verify | 90 | 0 | 16 | 2 | 106 | ❗ | | Fulfillment | 4 | 0 | 30 | 0 | 34 | ✅ | | Release | 12 | 0 | 0 | 2 | 12 | ❗ | | Analytics | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 6 | 0 | 6 | ➖ | | Configure | 0 | 0 | 6 | 0 | 6 | ➖ | | Secure | 12 | 0 | 4 | 4 | 16 | ❗ | | Version sanity check | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 2 | 0 | 2 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 778 | 0 | 102 | 14 | 880 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
added 2 commits
- A deleted user
added feature flag label
- Resolved by Rajendra Kadam
added 2 commits
- Resolved by Rajendra Kadam
- Resolved by Rajendra Kadam
- Resolved by Rajendra Kadam
added 99 commits
-
aac7098f...f1759c23 - 98 commits from branch
master
- a0f0f22d - Add slash command for incident declare
-
aac7098f...f1759c23 - 98 commits from branch
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
@.luke - Do you mind taking a look, please?
I think that verification of this MR and others that involve slack, will need to be sent through ~"group::integrations" as it needs slack setup to test.
This only adds the command to
help
command and makes it work for someone sending the command. Once this is merged, I will update the command to open the modal.I broke down this MR from !100795 (diffs)
requested review from @.luke
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as incomplete
removed featureenhancement label
- Resolved by Rajendra Kadam
@rkadam3 - please see the following guidance and update this merge request.1 Warning Please add a subtype label to this merge request. If you have added a type label and do not feel the purpose of this merge request matches one of the subtypes labels, please resolve this discussion.
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Alex Kalderimis
Thanks, @rkadam3! It looks like this is on the right track. I've left some suggestions and questions. Please send back when ready!
removed review request for @.luke
changed milestone to %15.6
requested review from @.luke
added 2 commits
mentioned in issue #344856 (closed)
added 1 commit
- 4fbb48e4 - Add spec for collection method to improve coverage
added workflowin review label and removed workflowready for development label
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
removed review request for @.luke
added featureenhancement label
added 2 commits
added 2197 commits
-
59d91076...4610a545 - 2196 commits from branch
master
- b4e82868 - Add slash command for incident declare
-
59d91076...4610a545 - 2196 commits from branch
requested review from @.luke
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
@.luke
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
removed review request for @.luke
requested review from @.luke
removed review request for @.luke
requested review from @alexkalderimis
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added 992 commits
-
c4e694ba...d015dcc4 - 990 commits from branch
master
- dd479169 - Add slash command for incident declare
- b423d11f - Remove diable cop line
-
c4e694ba...d015dcc4 - 990 commits from branch
mentioned in merge request !102605 (merged)
- Resolved by Alex Kalderimis
I am encountering issues when trying to QA this - I can successfully update the slack app with my gitpod domain, but I get
/dev-gitlab failed with the error "dispatch_failed"
for both help andincident declare
.
- Resolved by Alex Kalderimis
- Resolved by Alex Kalderimis
This broadly looks fine to me - my main issues today have been with QA'ing this. @rkadam3 - if you can provide a video of this working, I think that will be fine
I am assuming @.luke's approval here, since he passed this on to me.
@alexkalderimis Yes, I approved, thanks for checking. There is still a system note !101177 (comment 1155395624) but the approval must have been dropped after the branch was rebased.
Edited by Luke Duncalfe
enabled an automatic merge when the pipeline for edaa2990 succeeds
mentioned in commit 5c06d350
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue #382353 (closed)
mentioned in merge request !104045 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
@Taucher2003 Files of your interest have been changed:
- lib/gitlab/slash_commands/command.rb
mentioned in issue gitlab-org/quality/triage-reports#15286 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15711 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16018 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16480 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17014 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17461 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17921 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18454 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18933 (closed)
mentioned in issue gitlab-org/quality/triage-reports#19387 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20617 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20983 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21548 (closed)
mentioned in issue gitlab-org/quality/triage-reports#22039