Skip to content
Snippets Groups Projects

Add `incident declare` slash command with base logic

Merged Rajendra Kadam requested to merge 344856-add-incident-declare-slash-command-part-1 into master
1 unresolved thread

What does this MR do and why?

Adds base code for incident declare slash command.

This change is behind a feature flag and is disabled by default.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

  1. Follow the steps mentioned in https://gitlab.com/gitlab-org/manage/integrations/team/-/blob/main/integrations/slack.md for setting up a slack workspace to test the command.
  2. Enable the FF per user to see it on the list of commands if that specific user sends a command.
  3. Try using /dev-gitlab help to check the list of commands. If FF is disabled, it does not show /dev-gitlab incident declare in the list of commands. If the FF is enabled, then it shows up.
  4. Try using /dev-gitlab incident declare. If FF is disabled, it shows that the command is invalid, if FF is enabled, it shows It works! in the slack message.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #344856 (closed)

Edited by Rajendra Kadam

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Rajendra Kadam added 1 commit

    added 1 commit

    Compare with previous version

  • Rajendra Kadam added 2 commits

    added 2 commits

    Compare with previous version

  • Rajendra Kadam added 1 commit

    added 1 commit

    Compare with previous version

  • Rajendra Kadam resolved all threads

    resolved all threads

  • Rajendra Kadam
  • Rajendra Kadam changed the description

    changed the description

  • Rajendra Kadam added 99 commits

    added 99 commits

    Compare with previous version

  • Rajendra Kadam marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Author Maintainer

    @.luke - Do you mind taking a look, please?

    I think that verification of this MR and others that involve slack, will need to be sent through ~"group::integrations" as it needs slack setup to test.

    This only adds the command to help command and makes it work for someone sending the command. Once this is merged, I will update the command to open the modal.

    I broke down this MR from !100795 (diffs)

  • Rajendra Kadam requested review from @.luke

    requested review from @.luke

  • Rajendra Kadam marked this merge request as ready

    marked this merge request as ready

  • Rajendra Kadam changed title from Add slash command with base logic to Add {+incident declare +}slash command with base logic

    changed title from Add slash command with base logic to Add {+incident declare +}slash command with base logic

  • Rajendra Kadam marked the checklist item I have evaluated the MR acceptance checklist for this MR. as incomplete

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as incomplete

  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe removed review request for @.luke

    removed review request for @.luke

  • Luke Duncalfe changed milestone to %15.6

    changed milestone to %15.6

  • Rajendra Kadam added 1 commit

    added 1 commit

    • f0b83989 - Apply reviewer suggestions part 1

    Compare with previous version

  • Rajendra Kadam added 1 commit

    added 1 commit

    • 75a0d400 - Fix issues with review suggestions

    Compare with previous version

  • Rajendra Kadam added 1 commit

    added 1 commit

    • e87bba7d - Apply reviewer suggestions part 2

    Compare with previous version

  • Rajendra Kadam added 1 commit

    added 1 commit

    • f5b044c6 - Fix specs for the new suggestions

    Compare with previous version

  • Rajendra Kadam requested review from @.luke

    requested review from @.luke

  • Rajendra Kadam added 1 commit

    added 1 commit

    • e2d96848 - Remove redandunt method for allowed?

    Compare with previous version

  • Rajendra Kadam added 2 commits

    added 2 commits

    Compare with previous version

  • mentioned in issue #344856 (closed)

  • Rajendra Kadam added 1 commit

    added 1 commit

    • 4fbb48e4 - Add spec for collection method to improve coverage

    Compare with previous version

  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe removed review request for @.luke

    removed review request for @.luke

  • Rajendra Kadam added 1 commit

    added 1 commit

    • 44414bc1 - Apply reviewer suggestions 2

    Compare with previous version

  • Rajendra Kadam added 2 commits

    added 2 commits

    • ac95ed70 - Apply reviewer suggestions 2.1 for command filter
    • d5c45ed4 - Fix the cop error

    Compare with previous version

  • Rajendra Kadam added 1 commit

    added 1 commit

    Compare with previous version

  • Rajendra Kadam added 1 commit

    added 1 commit

    Compare with previous version

  • Rajendra Kadam added 2197 commits

    added 2197 commits

    Compare with previous version

  • Rajendra Kadam requested review from @.luke

    requested review from @.luke

  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe approved this merge request

    approved this merge request

  • :wave: @.luke, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • 🤖 GitLab Bot 🤖 added 1 deleted label

    added 1 deleted label

  • Luke Duncalfe removed review request for @.luke

    removed review request for @.luke

  • Luke Duncalfe unapproved this merge request

    unapproved this merge request

  • Rajendra Kadam added 1 commit

    added 1 commit

    Compare with previous version

  • Rajendra Kadam requested review from @.luke

    requested review from @.luke

  • Luke Duncalfe approved this merge request

    approved this merge request

  • Luke Duncalfe removed review request for @.luke

    removed review request for @.luke

  • requested review from @alexkalderimis

  • Rajendra Kadam marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Rajendra Kadam added 992 commits

    added 992 commits

    Compare with previous version

  • Rajendra Kadam mentioned in merge request !102605 (merged)

    mentioned in merge request !102605 (merged)

  • Alex Kalderimis
  • Alex Kalderimis approved this merge request

    approved this merge request

  • Alex Kalderimis resolved all threads

    resolved all threads

  • Alex Kalderimis enabled an automatic merge when the pipeline for edaa2990 succeeds

    enabled an automatic merge when the pipeline for edaa2990 succeeds

  • Alex Kalderimis mentioned in commit 5c06d350

    mentioned in commit 5c06d350

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #382353 (closed)

  • Rajendra Kadam mentioned in merge request !104045 (merged)

    mentioned in merge request !104045 (merged)

  • @Taucher2003 Files of your interest have been changed:

    • lib/gitlab/slash_commands/command.rb
  • Please register or sign in to reply
    Loading