danger-review
Passed Started
by
@gitlab-bot

🤖 GitLab Bot 🤖
1Running with gitlab-runner 16.11.0~pre.21.gaa21be2d (aa21be2d)2 on blue-1.private.runners-manager.gitlab.com/gitlab.com/gitlab-org 1zzGUpzq, system ID: s_fc31da7ae46e3 feature flags: FF_NETWORK_PER_BUILD:true, FF_USE_IMPROVED_URL_MASKING:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 ...9Using docker image sha256:d3b0559cb24053166f3816eec3fca4c94ad4aa9b642386e3ff1bc7610456a8b3 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14@sha256:2d91cdf388bdf30ef221225e4493723278922b336b2798e1a11bddcb66be92aa ...11Running on runner-1zzgupzq-project-278964-concurrent-0 via runner-1zzgupzq-private-1713470033-9793aa7f...13Fetching changes with git depth set to 20...14Initialized empty Git repository in /builds/gitlab-org/gitlab/.git/15Created fresh repository.16remote: Enumerating objects: 142129, done. 17remote: Counting objects: 100% (142129/142129), done. 18remote: Compressing objects: 100% (95918/95918), done. 19remote: Total 142129 (delta 58594), reused 119539 (delta 40354), pack-reused 0 20Receiving objects: 100% (142129/142129), 129.39 MiB | 28.35 MiB/s, done.21Resolving deltas: 100% (58594/58594), done.23 * [new ref] refs/pipelines/1259323872 -> refs/pipelines/125932387224Checking out 6c4d4f05 as detached HEAD (ref is refs/merge-requests/149844/merge)...25Skipping Git submodules setup26$ git remote set-url origin "${CI_REPOSITORY_URL}"28Checking cache for ruby-gems-debian-bookworm-ruby-3.1-17...29Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/ruby-gems-debian-bookworm-ruby-3.1-17 30Successfully extracted cache31Checking cache for node-modules-debian-bookworm-test-17...32Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/node-modules-debian-bookworm-test-17 33Successfully extracted cache35Using docker image sha256:d3b0559cb24053166f3816eec3fca4c94ad4aa9b642386e3ff1bc7610456a8b3 for registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14:rubygems-3.4-git-2.36-lfs-2.9-chrome-123-yarn-1.22-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images/debian-bookworm-ruby-3.1.patched-golang-1.21-rust-1.73-node-20.12-postgresql-14@sha256:2d91cdf388bdf30ef221225e4493723278922b336b2798e1a11bddcb66be92aa ...36$ source scripts/utils.sh37$ bundle_install_script "--with danger"715$ yarn_install_script770$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${DANGER_GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command771$ if [ -z "${DANGER_GITLAB_API_TOKEN}" ]; then # collapsed multi-line command772Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/analytics_instrumentation.rb773Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/bulk_database_actions.rb774Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/change_column_default.rb775Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ci_templates.rb776Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/clickhouse.rb777Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/config_files.rb778Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/customer_success.rb779Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database.rb780Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/database_dictionary.rb781Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/datateam.rb782Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/experiments.rb783Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/feature_flag.rb784Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/gitlab_schema_validation.rb785Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/ignored_model_columns.rb786Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/master_pipeline_status.rb787Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/model_validations.rb788Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/multiversion.rb789Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/project_helper.rb790Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/required_stops.rb791Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/rubocop.rb792Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/saas_feature.rb793Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_args.rb794Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/sidekiq_queues.rb795Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/specs.rb796Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/stable_branch.rb797Importing plugin at /builds/gitlab-org/gitlab/danger/plugins/todos.rb798Importing rule analytics_instrumentation at /builds/gitlab-org/gitlab/danger/analytics_instrumentation799Importing rule architecture at /builds/gitlab-org/gitlab/danger/architecture800Importing rule bulk_database_actions at /builds/gitlab-org/gitlab/danger/bulk_database_actions801Importing rule ce_ee_vue_templates at /builds/gitlab-org/gitlab/danger/ce_ee_vue_templates802Importing rule change_column_default at /builds/gitlab-org/gitlab/danger/change_column_default803Importing rule changelog at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/changelog804Importing rule changes_size at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/changes_size805Importing rule ci_config at /builds/gitlab-org/gitlab/danger/ci_config806Importing rule ci_tables at /builds/gitlab-org/gitlab/danger/ci_tables807Importing rule ci_templates at /builds/gitlab-org/gitlab/danger/ci_templates808Importing rule clickhouse at /builds/gitlab-org/gitlab/danger/clickhouse809Importing rule commit_messages at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/commit_messages810Importing rule commits_counter at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/commits_counter811Importing rule config_files at /builds/gitlab-org/gitlab/danger/config_files812Importing rule customer_success at /builds/gitlab-org/gitlab/danger/customer_success813Importing rule database at /builds/gitlab-org/gitlab/danger/database814Importing rule datateam at /builds/gitlab-org/gitlab/danger/datateam815Importing rule documentation at /builds/gitlab-org/gitlab/danger/documentation816Importing rule duplicate_yarn_dependencies at /builds/gitlab-org/gitlab/danger/duplicate_yarn_dependencies817Importing rule eslint at /builds/gitlab-org/gitlab/danger/eslint818Importing rule experiments at /builds/gitlab-org/gitlab/danger/experiments819Importing rule feature_flag at /builds/gitlab-org/gitlab/danger/feature_flag820Importing rule gitaly at /builds/gitlab-org/gitlab/danger/gitaly821Importing rule gitlab_schema_validation at /builds/gitlab-org/gitlab/danger/gitlab_schema_validation822Importing rule ignored_model_columns at /builds/gitlab-org/gitlab/danger/ignored_model_columns823Importing rule master_pipeline_status at /builds/gitlab-org/gitlab/danger/master_pipeline_status824Importing rule metadata at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/metadata825Importing rule model_validations at /builds/gitlab-org/gitlab/danger/model_validations826Importing rule multiversion at /builds/gitlab-org/gitlab/danger/multiversion827Importing rule pipeline at /builds/gitlab-org/gitlab/danger/pipeline828Importing rule prettier at /builds/gitlab-org/gitlab/danger/prettier829Importing rule qa_selector at /builds/gitlab-org/gitlab/danger/qa_selector830Importing rule required_stops at /builds/gitlab-org/gitlab/danger/required_stops831Importing rule roulette at /builds/gitlab-org/gitlab/danger/roulette832Importing rule rubocop at /builds/gitlab-org/gitlab/danger/rubocop833Importing rule rubygems at /builds/gitlab-org/gitlab/danger/rubygems834Importing rule saas_feature at /builds/gitlab-org/gitlab/danger/saas_feature835Importing rule sidekiq_args at /builds/gitlab-org/gitlab/danger/sidekiq_args836Importing rule sidekiq_queues at /builds/gitlab-org/gitlab/danger/sidekiq_queues837Importing rule specialization_labels at /builds/gitlab-org/gitlab/danger/specialization_labels838Importing rule specs at /builds/gitlab-org/gitlab/danger/specs839Importing rule stable_branch_patch at /builds/gitlab-org/gitlab/danger/stable_branch_patch840Importing rule tailwindcss at /builds/gitlab-org/gitlab/danger/tailwindcss841Importing rule todos at /builds/gitlab-org/gitlab/danger/todos842Importing rule type_label at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/type_label843Importing rule utility_css at /builds/gitlab-org/gitlab/danger/utility_css844Importing rule vue_shared_documentation at /builds/gitlab-org/gitlab/danger/vue_shared_documentation845Importing rule z_add_labels at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/z_add_labels846Importing rule z_retry_link at /builds/gitlab-org/gitlab/vendor/ruby/3.1.0/gems/gitlab-dangerfiles-4.7.0/lib/danger/rules/z_retry_link847Results:848Messages:849- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:850If this merge request needs a changelog entry, add the `Changelog` trailer to the commit message you want to add to the changelog.851If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.852- [ ] This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is **recommended**. Reviews can happen after you merge.853Markdown:854## Documentation review855The following files require a review from a technical writer:856* `doc/user/clusters/agent/ci_cd_workflow.md` ([Link to current live version](https://docs.gitlab.com/ee/user/clusters/agent/ci_cd_workflow/))857* `doc/user/clusters/agent/user_access.md` ([Link to current live version](https://docs.gitlab.com/ee/user/clusters/agent/user_access/))858The review does not need to block merging this merge request. See the:859- [Metadata for the `*.md` files](https://docs.gitlab.com/ee/development/documentation/#metadata) that you've changed. The first few lines of each `*.md` file identify the stage and group most closely associated with your docs change.860- The [Technical Writer assigned](https://handbook.gitlab.com/handbook/product/ux/technical-writing/#assignments) for that stage and group.861- [Documentation workflows](https://docs.gitlab.com/ee/development/documentation/workflow.html) for information on when to assign a merge request for review.862## Reviewer roulette863| Category | Reviewer | Maintainer |864| -------- | -------- | ---------- |865| ~"backend" | `@hmehra` [{width=12}](https://gitlab.com/hmehra) {width=12} (UTC+10) | `@harsimarsandhu` [{width=12}](https://gitlab.com/harsimarsandhu) {width=12} (UTC+2) |866**Please check reviewer's status!**867- {width=12} Reviewer is available!868- {width=12} Reviewer is unavailable!869Please refer to [documentation page](https://docs.gitlab.com/ee/development/code_review.html#reviewer-roulette)870for guidance on how you can benefit from the Reviewer Roulette, or use the871[GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/)872to find other available reviewers.873**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/6663868769) that generated this comment.**875Not uploading cache ruby-gems-debian-bookworm-ruby-3.1-17 due to policy876Not uploading cache node-modules-debian-bookworm-test-17 due to policy878Job succeeded