Convert Onboarding::Status into a presenter construct

Currently, the Onboarding::Status class may be handling both data management and presentation logic. To improve separation of concerns and adhere to the Single Responsibility Principle, we should convert Onboarding::Status into a presenter construct.

Objectives

1. Replace Onboarding::Status with a new Onboarding::StatusPresenter class.
2. Onboarding::UserStatus and the Registration type classes remain focused on data management and business logic.
3. Update all relevant views and controllers to use the new presenter.

Expected Benefits

• Clearer separation of concerns between data management and presentation
• Improved testability of both the original Onboarding::UserStatus and the new presenter
• Enhanced maintainability and readability of the codebase
• Easier to extend or modify presentation logic without affecting core data structures

Implementation Steps

1. Create the Onboarding::StatusPresenter class.
2. Identify and move all presentation-related methods from Onboarding::Status to Onboarding::StatusPresenter.
3. Update views and controllers to use the new presenter instead of calling presentation methods directly on Onboarding::Status.
4. Ensure all existing functionality is maintained through the presenter.
5. Add unit tests for the new presenter class.
6. Update existing tests to reflect the changes.

Acceptance Criteria

• Onboarding::StatusPresenter is created and contains all presentation logic.
• Onboarding::UserStatus is refactored to focus solely on data management and business logic.
• All views and controllers are updated to use the new presenter.
• Existing functionality remains unchanged.
• New unit tests are added for Onboarding::StatusPresenter.
• All existing tests pass after the refactoring.

Additional Considerations

• Ensure backwards compatibility if this change affects any public APIs.

added gitlab-org#15847 (closed) as parent epic

changed milestone to %Backlog

added Next Up automation:ml devopsgrowth groupacquisition maintenancerefactor sectiongrowth typemaintenance workflowstart labels

assigned to @dstull

changed the description

marked this issue as blocked by #503175 (closed)

assigned to myself for now, but sending through regular refinement for visibility

added workflowplanning breakdown label and removed workflowstart label

added workflowrefinement label and removed workflowplanning breakdown label

Refinement

Welcome to the refinement stage for this issue. During this stage, engineers will ensure that this issue meets our criteria for issues ready for development.

Please follow these guidelines to ensure a thorough refinement:

• Verify the issue description and check that the requirements are present and well-defined
• Evaluate risks and dependencies
• Uncover blind spots if possible
• Outline possible technical solutions for the problem

Make sure every outcome of the refinement discussion is included in the issue's description. We want to avoid needing to go over multiple comments and threads to figure out what is the decision or additional requirement. The description should be the single source of truth when it comes to implementation details.

As an engineer, please:

• Discuss and update the issue description (if needed)
• Apply a weight estimate by voting or (if above 5) - means it's likely too big and needs splitting into smaller issues (also please suggest how by starting a discussion)
• Ensure the issue has a ~type label

This issue will be considered as completed with refinement if it receives 3 unique weight estimations, and moved to workflowscheduling afterwards.

/cc @gitlab-org/growth/engineers

This message was generated automatically. Improve it or delete it.

set weight to 2

added workflowscheduling label and removed workflowrefinement label

changed weight to 3 from 2

added workflowin dev label and removed workflowscheduling label

changed milestone to %17.6

mentioned in commit 8f3a5cac

mentioned in merge request !172717 (merged)

mentioned in commit ae7afe3a

mentioned in commit d140f29f

added workflowin review label and removed workflowin dev label

mentioned in commit 2bbeb929

mentioned in commit 1582b85f

changed milestone to %17.7

added missed:17.6 label

marked the checklist item Onboarding::StatusPresenter is created and contains all presentation logic. as completed

marked the checklist item Onboarding::UserStatus is refactored to focus solely on data management and business logic. as completed

marked the checklist item All views and controllers are updated to use the new presenter. as completed

marked the checklist item Existing functionality remains unchanged. as completed

marked the checklist item New unit tests are added for Onboarding::StatusPresenter. as completed

marked the checklist item All existing tests pass after the refactoring. as completed

@p_cordero can you help verify this one?

Merely any type of user signup will verify it. Can be done in production. All I am looking for is a 'it works and no regressions'

added workflowverification label and removed workflowin review label

closed

The workflow label was automatically updated to workflowcomplete because you closed the issue while in workflowverification.

If this is not the correct label, please update.

To avoid this message, update the workflow label as you close the issue. This message was generated automatically. Improve it or delete it.

added workflowcomplete label and removed workflowverification label