Do not parse JSON for access dropdown when it's undefined

We have quite a number of "undefined" is not valid JSON errors logged to Sentry. It goes in tens of thousands a month. Here are some examples:

• example 1 (internal only)
• example 2 (internal only)

The errors can be seen in the browser's console, when opening Project > Settings > Repository

Implementation guidelines

We do have a try/catch block for preselectedItems. That's where we're logging the error to Sentry.

I think we should add a check before that try/catch and not try to parse undefined. That will clear our logs a bit and leave only those errors that are a result of an unsuccessful parsing, such as this one (internal only).

changed milestone to %Backlog

added Category:Source Code Management frontend groupsource code maintenancerefactor labels

set weight to 1

added typemaintenance label

added devopscreate sectiondev labels

changed milestone to %17.6

marked this issue as related to #432534 (closed)

mentioned in issue #432534 (closed)

changed the description

added Seeking community contributions label

This is a duplicate of #432534 (closed), but this one has the implementation guide so I decided to keep this open.

mentioned in merge request !168103 (merged)

Hi @psjakubowska Could you assign this issue to me, please? I've created a corresponding MR !168103 (merged)

assigned to @antonkalmykov and @psjakubowska

removed Seeking community contributions label

mentioned in commit c825dcf0

added workflowverification label

closed

added workflowcomplete label and removed workflowverification label