Reviewing unresolved comments using the review panel
Caution
Proposal will change as the review panel is functionality is related to the existing Activity feed #474799 (comment 2355695909)
Proposal
Use the review panel #474794 to help filter reviewer reviews from the rest of comments and system notes that appear in a merge request.
Benefits:
- Consistency between starting and consuming a review #474794
- Provides a way to have a filtered view of the review flow from requests, comments, and review feedback states.
| Select reviewer | Display of review in drawer |
|---|---|
 |
 |
Functionality
- Displays current reviewer and the current state of the review (related #474800)
- Option to "re-request review" via button in drawer
- Ability to navigate next/prev comment using the unresolved threads buttons
- An MVC fallback to manage scope is to just to use a label "X unresolved threads".
- Default shows key points of unresolved threads
- Shows closest review requests and review feedback points when displaying unresolved comments
- Clicking on the comment navigates the user to that comment in the review.
- Code changes will jump to the "Changes" tab
- Users can filter between unresolved threads and the full activity view by using the filter.
- In the future there could be more items to filter on
- Timeline displays the following
- System notes (small dot for review requests)
- Unresolved comments (status-waiting)
- Resolved comments (status-success)
- Review feedback (status-X icon with extra background color)
- The order of the timeline should match what is in the activity feed
- Related reasoning Use reverse order for timeline entries for batc... (#9137 - closed)
| Unresolved threads with filter open | Full activity |
|---|---|
 |
 |
Concept: When viewing a reviewer's review it changes the state of the "unresolved threads"
This idea here is one that may need to be critiqued further.
When viewing a reviewer's review it changes the state of the "unresolved threads".
- Clicking on the avatar will open the reviewer's review in the panel. This helps with handling the scenario where the user is on the Changes tab and would like the entire screen real estate for the file diff but would like to return to the review.
- There would be a dropdown menu option from the overflow menu to "Show all unresolved threads" which would remove the reviewer's avatar.
| Panel open | Panel closed but current reviewer's context is in the unresolved threads element |
|---|---|
 |
 |
Background
When creating a review, we already have this concept that a review is a list of comments that can appear in various areas. Comments of a review can appear in the Overview and Changes tab. They could be standalone threads that need to be resolved or they could be replies other other threads.
We are taking that idea from the area of creating a review to the stage of understanding a review without introducing a new way of managing comments in a new tab.