Use reverse order for timeline entries for batch comments (reviews) on merge requests
Problem to solve
When you add multiple comments during a code review the order of the timeline entries for each comment appears in reverse order when compared to what the reviewer is viewing while inspecting the batch comments on the file changes. This can lead to a couple of issues, in contrast, to manually adding the comments one by one. Most of the times it won't make any difference since all comments should be addressed eventually. However, I've run into the following scenario a couple of times where the reviewer is referencing another comment by typing ...see comment above or ...see comment below which can be inaccurate on the merge request timeline.
During review | After review |
---|---|
Proposal
Use reverse order for timeline entries for batch comments (reviews) on merge requests. This would allow the reviewer to evaluate review comments based on the linear order they appear on the file changes and expect these comments to appear in the same linear order after submitting the review. In the future, this could support chronological order of the comments which could allow the reviewer to indicate order or priority if needed.
What does success look like, and how can we measure that?
The user will feel confident that batch comments will appear in order as expected.