Analyse and remove unused onboarding_progresses columns

We believe that there are certain columns in the onboarding_progresses table below that may not be used today. See discussion in &13634 (comment 1890116505)

CREATE TABLE onboarding_progresses (
    id bigint NOT NULL,
    namespace_id bigint NOT NULL,
    created_at timestamp with time zone NOT NULL,
    updated_at timestamp with time zone NOT NULL,
    git_pull_at timestamp with time zone,
    git_write_at timestamp with time zone,
    merge_request_created_at timestamp with time zone,
    pipeline_created_at timestamp with time zone,
    user_added_at timestamp with time zone,
    trial_started_at timestamp with time zone,
    subscription_created_at timestamp with time zone,
    required_mr_approvals_enabled_at timestamp with time zone,
    code_owners_enabled_at timestamp with time zone,
    scoped_label_created_at timestamp with time zone,
    security_scan_enabled_at timestamp with time zone,
    issue_auto_closed_at timestamp with time zone,
    repository_imported_at timestamp with time zone,
    repository_mirrored_at timestamp with time zone,
    issue_created_at timestamp with time zone,
    secure_dependency_scanning_run_at timestamp with time zone,
    secure_container_scanning_run_at timestamp with time zone,
    secure_dast_run_at timestamp with time zone,
    secure_secret_detection_run_at timestamp with time zone,
    secure_coverage_fuzzing_run_at timestamp with time zone,
    secure_cluster_image_scanning_run_at timestamp with time zone,
    secure_api_fuzzing_run_at timestamp with time zone,
    license_scanning_run_at timestamp with time zone,
    code_added_at timestamp with time zone
);

Solution

  • Analyze the onboarding progress code and invocations to see if any of these columns are not filled out or observed in any way.
  • Note any discrepancies where we maybe recording the data, but not visualizing it in LearnGitLab, or vice-versa, as a separate follow-up issue for discussion
  • Remove any column that is no longer referenced columns from this table.
    • verify/coordinate with data team first. See #461074 (comment 1900686530)
      • verified that this table's use is deprecated in data side, ok to remove, see https://gitlab.com/gitlab-org/gitlab/-/issues/467305#note_2002328605

Progress

  • %17.3: Ignore unused columns: !160892 (merged)
  • %17.4 : Drop the columns: !162756 (merged)
  • %17.5 : Remove the ingore: #480046 (closed)
Edited Aug 20, 2024 by Roy Liu
Assignee Loading
Time tracking Loading