Follow-up: Add UI components for Beyond Identity check exclusions by Projects
The following discussions from !150664 (merged) should be addressed:
-
@ekigbo started a discussion: nitpick: this could be a computed
showEmptyState
-
@ekigbo started a discussion: nitpick: similar to above, could be
canRemoveExclusion
-
@ekigbo started a discussion: nitpick: this could also be computed property
-
@ekigbo started a discussion: nitpick: rather than a string check, perhaps we can pass in a boolean flag?
-
@ekigbo started a discussion: nitpick: we dont really need this, since we default this to
true
wrapper = createComponent();
-
@ekigbo started a discussion: nitpick: we could add an additional assertion to make sure both items added to the list of exclusions are there.
This is implicitly covered checking that the selected items match the
exclusionsMock
but it wasnt clear thatexclusionsMock
contains 2 and only 2 items without jumping out into the mock file.expect(findListSelector().props('selectedItems')).toHaveLength(2);
there was a flash of "No results found" while projects are loading. [in the project selection dropdown]