XS Add sharding key YAML config to ci_builds & p_ci_builds (1 table)
What we need to do
The ci_builds
table has a project_id
key, but didn't get the designation automatically a few months ago when the Cells team sent out all the initial MRs.
I'm not sure if there's something blocking this having to do with partitioning.
How to do it
- Find out if there's any reason we can't add the sharding key designation immediately and have all the automation work.
- Open up https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/docs/ci_builds.yml
---
table_name: ci_builds
classes:
- Ci::Bridge
- Ci::Build
- Ci::Processable
- CommitStatus
- GenericCommitStatus
feature_categories:
- continuous_integration
description: TODO
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/commit/046b28312704f3131e72dcd2dbdacc5264d4aa62
milestone: '8.0'
gitlab_schema: gitlab_ci
+ sharding_key:
+ project_id: projects
Designs
- Show closed items
Blocks
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- drew stachon added to epic &12323
added to epic &12323
- drew stachon changed milestone to %Backlog
changed milestone to %Backlog
- drew stachon changed the description
Compare with previous version changed the description
- drew stachon mentioned in issue #458490 (closed)
mentioned in issue #458490 (closed)
- drew stachon mentioned in epic &13074 (closed)
mentioned in epic &13074 (closed)
- drew stachon mentioned in epic &12323
mentioned in epic &12323
- drew stachon changed title from Add sharding key designation to ci_builds (1 table) to XS Add sharding key designation to ci_builds (1 table)
changed title from Add sharding key designation to ci_builds (1 table) to XS Add sharding key designation to ci_builds (1 table)
- drew stachon changed title from XS Add sharding key designation to ci_builds (1 table) to XS Add sharding key YAML config to ci_builds (1 table)
changed title from XS Add sharding key designation to ci_builds (1 table) to XS Add sharding key YAML config to ci_builds (1 table)
- drew stachon mentioned in issue #448630 (closed)
mentioned in issue #448630 (closed)
- Caroline Simpson changed milestone to %17.1
changed milestone to %17.1
- Caroline Simpson added Engineering Time label
added Engineering Time label
- Caroline Simpson added VerifyP1 label
added VerifyP1 label
added Deliverable cicdactive workflowready for development labels
- Caroline Simpson set weight to 1
set weight to 1
- Caroline Simpson mentioned in issue gitlab-org/ci-cd/pipeline-execution#209 (closed)
mentioned in issue gitlab-org/ci-cd/pipeline-execution#209 (closed)
- Subashis Chakraborty mentioned in epic &13087 (closed)
mentioned in epic &13087 (closed)
- Caroline Simpson marked this issue as related to #454946 (closed)
marked this issue as related to #454946 (closed)
- Caroline Simpson removed the relation with #454946 (closed)
removed the relation with #454946 (closed)
- Caroline Simpson marked this issue as blocking #454946 (closed)
marked this issue as blocking #454946 (closed)
- Subashis Chakraborty mentioned in issue #454946 (closed)
mentioned in issue #454946 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17612 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17612 (closed)
- Maintainer
Setting health status to
on track
as the milestone has just begun.Issue participants are welcome to override this by setting the health status to another value.
- 🤖 GitLab Bot 🤖 changed health status to on track
changed health status to on track
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17715 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17715 (closed)
- Developer
Experimental AI Estimation Thread Collapse replies - Developer
Estimated weight: 3.0 Estimated days for development: 5.0 Estimated number of MRs: 4.0
Estimates are generated based on historical work effort from issues that may be similar. The issues that were used to generate this data were as follows.
- S Add sharding_key to p_ci_job_artifacts (#439686 - closed)
- Refactor schema_spec to support composite FKs (#388793 - closed)
- Remove `token` column from `ci_builds` (#339192 - closed)
- PoC for understanding uniqueness constraints ac... (#360148 - closed)
- Switch current partition_id value to 101 for ci... (#387810 - closed)
- Reorder primary key columns for ci_runner_machi... (#397014 - closed)
- Drop the default partition_id value from the pa... (#377822 - closed)
- Switch current partition_id value to 101 for ci... (#428985 - closed)
- Remove `index_ci_builds_on_token_partial` index... (#339191 - closed)
- Backend: Add `partition_id` column to selected ... (#364393 - closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17797 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17797 (closed)
- Caroline Simpson changed due date to June 14, 2024
changed due date to June 14, 2024
- Max Fan removed the relation with #454946 (closed)
removed the relation with #454946 (closed)
- Max Fan marked this issue as blocked by #454946 (closed)
marked this issue as blocked by #454946 (closed)
- Max Fan added workflowblocked label and removed workflowready for development label
added workflowblocked label and removed workflowready for development label
- Max Fan changed title from XS Add sharding key YAML config to ci_builds (1 table) to XS Add sharding key YAML config to ci_builds & p_ci_builds (1 table)
changed title from XS Add sharding key YAML config to ci_builds (1 table) to XS Add sharding key YAML config to ci_builds & p_ci_builds (1 table)
- Max Fan marked this issue as blocking #458479 (closed)
marked this issue as blocking #458479 (closed)
- Caroline Simpson changed milestone to %17.3
changed milestone to %17.3
- Caroline Simpson changed due date to August 09, 2024
changed due date to August 09, 2024
- Pedro Pombeiro marked this issue as blocking #459994 (closed)
marked this issue as blocking #459994 (closed)
- Pedro Pombeiro mentioned in merge request !155112 (closed)
mentioned in merge request !155112 (closed)
- Arturo Herrero mentioned in issue #458479 (closed)
mentioned in issue #458479 (closed)
- Pedro Pombeiro marked this issue as blocking #459997 (closed)
marked this issue as blocking #459997 (closed)
- Pedro Pombeiro marked this issue as blocking #459999 (closed)
marked this issue as blocking #459999 (closed)
- Pedro Pombeiro mentioned in issue gitlab-runner#36943 (closed)
mentioned in issue gitlab-runner#36943 (closed)
- Chun Du mentioned in issue gitlab-org/database-team/team-tasks#447 (closed)
mentioned in issue gitlab-org/database-team/team-tasks#447 (closed)
- Contributor
Hi @mfanGitLab - is this issue too no longer blocked now that #454946 (closed) is complete?
/cc @carolinesimpson
Collapse replies - Maintainer
ah sorry, no. It's not ready I've updated the linked items. It's blocked until the table has a
not-null
constraint set. Otherwise specs will fail - Developer
FYI we set the sharding key for
p_ci_builds
in !162823 (merged) - Developer
Update
- The sharding key for
p_ci_builds
was set in Add desired sharding keys for pipeline security (!162823 - merged)
The work for this issue is now completed, closing it.
- The sharding key for
- Developer
@morefice Thank you
- Max Fan marked this issue as blocked by #463406 (closed)
marked this issue as blocked by #463406 (closed)
- Caroline Simpson changed milestone to %17.4
changed milestone to %17.4
- Caroline Simpson assigned to @panoskanell
assigned to @panoskanell
- Caroline Simpson added candidate17.4 label
added candidate17.4 label
- Caroline Simpson changed milestone to %Next 1-3 releases
changed milestone to %Next 1-3 releases
- Cheryl Li added verify cells label and removed severity2 label
added verify cells label and removed severity2 label
- Pedro Pombeiro mentioned in issue #442395
mentioned in issue #442395
- Max Orefice mentioned in merge request !162823 (merged)
mentioned in merge request !162823 (merged)
- Max Orefice closed
closed
- Panos Kanellidis added workflowcomplete label and removed workflowblocked label
added workflowcomplete label and removed workflowblocked label
- Mark Nuzzo mentioned in epic gitlab-org#14749
mentioned in epic gitlab-org#14749
- service-epic-status-automation mentioned in epic &14749
mentioned in epic &14749
- service-epic-status-automation mentioned in epic &12383
mentioned in epic &12383
- Developer
Hello @panoskanell @morefice grouptenant scale noticed that this issue is closed, but it is still mentioned as
sharding_key_issue_url
in the table's database dictionary here.Sharding key issue URLs are supposed to remain open until the work on sharding keys is complete. If the work on this table is complete,
sharding_key_issue_url
can be removed from theyml
.Could you please make sure that either:
- An open issue is present in the
yml
forci_builds
table? - Or, if the work is complete, the
sharding_key_issue_url
is removed from theyml
?
Thank you
Edited by Shubham Kumar - An open issue is present in the
Collapse replies - Developer
Thank you @shubhamkrai
@morefice We should be good to remove this, right?
1 - Developer
Good catch!
We should be good to remove this, right?
Yes definitely, just opened !165181 (merged) to tackle this
Edited by Max Orefice 2
- Max Orefice mentioned in merge request !165181 (merged)
mentioned in merge request !165181 (merged)
- Pedro Pombeiro mentioned in merge request !165209 (merged)
mentioned in merge request !165209 (merged)
- drew stachon mentioned in epic gitlab-org#12323
mentioned in epic gitlab-org#12323