GitLab stores the secret data required for two-factor authentication (2FA) in an encrypted database column. The encryption key for this data is known as otp_key_base, and is stored in config/secrets.yml.
Decide what to do with this secret with respect to Cells
If you are unsure about the correct group, please do not leave the issue without a group label, and refer to
GitLab's shared responsibility functionality guidelines
for more information on how to triage this kind of issue.
fyi @bdenkovych. As part of 17.0 plan I'll schedule a few of these to make sure we have resolution. We may do that sooner than 17.0 as well, but that's milestone is planned, and there may be bandwidth limitations.
Rémy Coutablechanged title from [Cells 1.0] Decide what to do with otp_key_base to [Cells 1.0] (Size: S) Decide what to do with otp_key_base
changed title from [Cells 1.0] Decide what to do with otp_key_base to [Cells 1.0] (Size: S) Decide what to do with otp_key_base
Rémy Coutablechanged title from [Cells 1.0] (Size: S) {-Decide what to do with otp_key_base-} to [Cells 1.0] (Size: S) {+Migrate otp_key_base to an encrypted ApplicationSetting attribute+}
changed title from [Cells 1.0] (Size: S) {-Decide what to do with otp_key_base-} to [Cells 1.0] (Size: S) {+Migrate otp_key_base to an encrypted ApplicationSetting attribute+}
I'm circling back to this. I think for critical secrets that are part of the GitLab application, it actually makes more sense to keep them as secrets (i.e. config/secrets.yml). I think it makes sense to keep secrets for external services inside ApplicationSetting, since these are optional and meant to be configured through the admin/API.
Rémy Coutablechanged title from [Cells 1.0] (Size: S) Migrate {-otp_key_base to an encrypted ApplicationSetting attribute-} to [Cells 1.0] (Size: S) Migrate {+to devise-two-factor 5.x, which will make otp_key_base useless+}
changed title from [Cells 1.0] (Size: S) Migrate {-otp_key_base to an encrypted ApplicationSetting attribute-} to [Cells 1.0] (Size: S) Migrate {+to devise-two-factor 5.x, which will make otp_key_base useless+}
Rémy Coutablechanged the descriptionCompare with previous version