Fix db transaction on FogBugz importer

On FogBugz importer, all notes related to an issue are created in a single transaction, which may be a problem if there are too many notes since the transaction will be open for a long time.

Proposed solution

I believe the DB transaction is unnecessary, and we can remove it.

Also, we don't need to update the created_at and updated_at after creating the number if we include the attribute importing: true

For example we can create the note like:

Note.create!(
  project_id: project.id,
  noteable_type: "Issue",
  noteable_id: issue.id,
  author_id: author_id,
  note: body,
  created_at: date,
  updated_at: date,
  importing: true
)

added Category:Importers Importer:FogBugz backend devopsmanage groupimport and integrate sectioncore platform typemaintenance labels

set weight to 2

changed the description

changed milestone to %16.10

mentioned in issue #439825 (closed)

added workflowready for development label

mentioned in issue gitlab-org/manage/general-discussion#17666

@ivaneG Would you be interested in picking this up as your first issue?

Here's the public documentation for FogBugz in case you need it.

assigned to @ivaneG

mentioned in issue gitlab-org/quality/triage-reports#16269 (closed)

mentioned in commit ab50a752

mentioned in commit 55c1072a

mentioned in merge request !144495 (merged)

I have created the following MR: !144495 (merged) to cover the changes required for this issue.

mentioned in commit 054b76bf

mentioned in commit b13bb4e2

I am not sure if this is the expected behaviour but the FogBugz importer expects the first event/note to always have 'sVerb' = 'Opened'.

https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/fogbugz_import/importer.rb#L152

• If there are no events with 'sVerb' = 'Opened' the importer will skip all the events.
• If there are events before the event with the 'sVerb' = 'Opened' the imported will skip all the events before the one with the 'sVerb' = 'Opened'.

While testing the importer, I noticed there were some cases/issues created by the FogBugz platform that didn't have the event with 'sVerb' = 'Opened'. For those cases the vents are not being imported.

added workflowin review label and removed workflowready for development label

added Deliverable milestonep3 labels

Setting health status to on track as the milestone has just begun.

Issue participants are welcome to override this by setting the health status to another value.