January 29, 2024 - Import and Integrate Backlog Refinement
Engineers
Reply to each top-level comment with your refinements, using this template:
[...Explanation of your estimate, thoughts, or considerations...]
- **Weight**: ...
- **Issue / MR breakdown**:
-
Remember to keep any clarifying discussion in the issues themselves. -
Remember to be careful what you discuss here about confidential issues.
When you have refined all of the issues then unassign yourself.
Engineering Manager
When this issue is due, for each issue that was refined:
- Assign a weight.
- Remove the ready for next refinement label.
- Add the workflowready for development label.
Click to see a template to use.
Issue was refined in <link to this issue>.
/weight <weight>
/unlabel ~"ready for next refinement"
/label ~"workflow::ready for development"
You can then close this issue.
Issues
- (confidential)
- Automate the process for self-managed to update their GitLab for Slack app manifest
- Unable to import project into nested group using just `path' field via API
- Log every time an import is stopped before finishing
- Export gets stuck for large projects
- API access to "Recent Events" for webhooks
- (confidential)
- GitHub importer seems to miss some branch protection rules
- Allow direct transfer migration to be easily stopped by Admin
- Allow BB Cloud migration to be easily stopped by Admin
- Webhooks: value for update push_events_branch_filter is being interpreted as wildcard
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Martin Wortschack changed due date to February 05, 2024
changed due date to February 05, 2024
added devopsmanage groupimport and integrate meta sectiondev typeignore labels
- Martin Wortschack assigned to @wortschi, @georgekoltsov, @.luke, @justin_ho, @rodrigo.tomonari, @carlad-gl, @bmarjanovic, @jnutt, @SamWord, and @ivaneG
assigned to @wortschi, @georgekoltsov, @.luke, @justin_ho, @rodrigo.tomonari, @carlad-gl, @bmarjanovic, @jnutt, @SamWord, and @ivaneG
- Author Maintainer
(confidential) https://gitlab.com/gitlab-org/gitlab/-/issues/294168
Collapse replies - Maintainer
Based on https://gitlab.com/gitlab-org/gitlab/-/issues/294168#note_1741707172 and the assumption that saving the argument somewhere will be reasonably straight forward:
- Weight: 3
- Issue / MR breakdown: 1-2
- Maintainer
Oh, wait, there's another issue in this refinement issue that might solve this #437894 (closed).Edited by Luke Duncalfe 1 - Maintainer
I also think that we should use #437894 (closed) to solve this.
1
- Author Maintainer
Automate the process for self-managed to update their GitLab for Slack app manifest #401920
Collapse replies - Maintainer
Based on the comment, we should be able to improve the process. Additionally, we should do some UI polish, and error handling.
- Weight: backend-weight2 + frontend-weight1
- Issue / MR breakdown: 1-2 merge requests
- Documentation: update
- Author MaintainerEdited by Justin Ho Tuan Duong
Collapse replies - Maintainer
This requires an extra check, but the reported typebug is indeed valid. Per comment:
- Weight: backend-weight2
- Issue / MR breakdown: 1-2 merge requests
- Author MaintainerEdited by Justin Ho Tuan Duong
Collapse replies - Maintainer
Identifying every place where we halt an import without logging or error reporting may require additional time. While Jessie has pointed out some locations, we need to review our importers and consistently implement new logging practices. Additionally, it could be beneficial to establish a centralized logging mechanism serving as a SSOT for our importers.
- Weight: backend-weight3
- Issue / MR breakdown: Multiple merge requests
3 - Maintainer
I agree we could do extra investigative work to find other examples of where an import can stop. That activity could be something we timebox to, say, a day, because it could be impossible to find everything (the last one in the issue description #432927 took me a while to work out, for example!).
If we timebox the investigation side, it could become a small weight?
- Weight: 2
- Issue / MR breakdown: 1 MR
1
- Author MaintainerEdited by Justin Ho Tuan Duong
Collapse replies - Maintainer
I replied a couple of weeks ago #436638 (comment 1726742752) at the time, according to the helpful debug details in the description, it looked a lot like the archive was able to be exported (when they were doing it manually on the Rails console as a troubleshooting workaround) and the user was looking in a temporary file directory that gets cleaned up after the export. I'm not sure what else to do until they reply.Edited by Luke Duncalfe - Author Maintainer
I reached out to the user in #436638 (comment 1776403384) again. I'll remove this from our refinement backlog for now until we hear back from them.
- Author Maintainer
API access to "Recent Events" for webhooks #437188 (closed) backend
Edited by Justin Ho Tuan Duong Collapse replies - Maintainer
Per #437188 (comment 1747558052), we can expend existing REST API to include logs. Therefore:
- Weight: backend-weight2
- Issue / MR breakdown: 1-2 merge requests
- Documentation: Needed
1 1
- Author Maintainer
(confidential) #437894 (closed)
Collapse replies - Maintainer
Based on Bojan's proposal #437894 (comment 1747851463), I'll guess-weigh:
- Weight: 3-4
- Issue / MR breakdown: 1-2 MR
Edited by Luke Duncalfe 1 - Maintainer
I think this change will require many changes and won't be simple to implement #437894 (comment 1758162490)
- Weight: 5
- Issue / MR breakdown: 2-3 MR
Edited by Rodrigo Tomonari 1
- Author Maintainer
GitHub importer seems to miss some branch protection rules #438137 (closed) backend
Edited by Justin Ho Tuan Duong Collapse replies - Maintainer
Given that this one is difficult to replicate, and we're not sure how the
ProtectedBranchImporter
is importing branches that end up not having protected, we might to need to add some weight to investigate this.- Weight: backend-weight3
- Issue / MR breakdown: 1 MR
Edited by Carla Drago
- Author Maintainer
Allow direct transfer migration to be easily stopped by Admin #438281 (closed) backend
Edited by Justin Ho Tuan Duong 1 Collapse replies - Maintainer
My reasoning here is the same as the BitBucket item, so if that gets revised up or down, I think the same applies here.
- Weight: backend-weight3
- Issue / MR breakdown: Multiple merge requests
- Author MaintainerEdited by Justin Ho Tuan Duong
Collapse replies - Maintainer
As per the suggested solution in the epic, updating the workers to bail out of a failed migration sounds relatively straightforward.
I think that would be one MR, while extra work would be needed on the front-end to add a button to update the project import state.
- Weight: backend-weight3
- Issue / MR breakdown: Multiple merge requests
1 - Maintainer
I made a comment in the epic that suggests implementing a
cancel
API endpoint to stop the import. That's a one MR with backend-weight3.- Another one to add controller action to be able to cancel via the UI backend-weight1
- Another one to add GraphQL mutation to be able to cancel via the UI backend-weight3
- Another one to add a centralized list of all imports in the admin UI backend-weight3 (backend only)
1
- Author Maintainer
Webhooks: value for update push_events_branch_filter is being interpreted as wildcard #438490 (closed) backend
Edited by Justin Ho Tuan Duong Collapse replies - Maintainer
As per #438490 (comment 1747606947), it should be quick win. Thus:
- Weight: backend-weight1
- Issue / MR breakdown: 1 MR
- Documentation: update
1
- Martin Wortschack mentioned in issue #439572 (closed)
mentioned in issue #439572 (closed)
- Justin Ho Tuan Duong unassigned @justin_ho
unassigned @justin_ho
- Bojan Marjanovic unassigned @bmarjanovic
unassigned @bmarjanovic
- Martin Wortschack mentioned in issue #438285
mentioned in issue #438285
- Martin Wortschack mentioned in issue #432927
mentioned in issue #432927
- Martin Wortschack closed
closed