Confusing message when job play button greyed out due to deployment safety
Summary
When a manual job is blocked by deployment safety due to a newer job to the same environment the message when hovering over the play button is You are not authorized to run this manual job
.
The [docs] say the message should be This deployment job does not run automatically and must be started manually, but it's older than the latest deployment, and therefore can't run
.
The message on the job page is better but could still be improved.
This will overwrite the latest deployment
is confusing because you can't actually overwrite the latest deployment since the job is blocked due to deployment safety being enabled. It would be better for the message to say the job is blocked to prevent overwriting the latest deployment.
Note - this is seen on a self-managed Gitlab 16.6.
Steps to reproduce
- Verify that the Prevent outdated deployment jobs setting is enabled.
- Run a pipeline with a manual job deploying to a specific environment. Don't run the manual job.
- Run another pipeline with a manual job deploying to the same environment and run the manual job.
- View the pipeline page for the first pipeline.
- The play button on the manual job will be disabled with the message from the summary.
- Disable the Prevent outdated deployment jobs setting.
- View the pipeline page again for the first pipeline. The play button on the same manual job is enabled.
What is the expected correct behavior?
The message when you hover over the greyed out play button should match the docs.