Remove danger-review dependency on .com
What is the GitLab engineering productivity problem to solve?
AFAIK we have a requirement for the dev environment to not be dependent .com
. Is this still the case?
If so, we should remove the current pipeline dependency on the danger-review template being included from the .com instance:
This was initially added to make the dev pipeline pass when we removed the built-in danger-review in favour of the upstream included template: Use danger-review from gitlab-org/quality/pipel... (!121867 - merged)
Problem identification checklist
-
The root cause of the problem is identified. -
The surface of the problem is as small as possible.
What are the potential solutions?
Option 1: Add extra rules to make this template not be attempted to be included in other environment other than .com. The Omnibus GitLab achieves this by:
- adding the include in the gitlab-ci-config/gitlab-com.yml.
- But only including this parent template in .com.
- This way the child template is never parsed.
Option 2: Mirror the upstream pipeline common project to the other environments that need them: Mirror gitlab.com/gitlab-org/quality/pipeline-c... (gitlab-org/quality/pipeline-common#32 - closed)
In both options we'd remove the include:remote
for an include: [project:..., file:...]
.
Maybe JiHu would also need this mirror.
-
All potential solutions are listed. -
A solution has been chosen for the first iteration: PUT THE CHOSEN SOLUTION HERE
Verify that the solution has improved the situation
-
The solution improved the situation. - If yes, check this box and close the issue. Well done!
🎉 - Otherwise, create a new "Productivity Improvement" issue. You can re-use the description from this issue, but another solution should be chosen this time.
- If yes, check this box and close the issue. Well done!