Unselected advanced search facets not loading after search term entered

Summary

When I run a search from the modal and then land on the advanced search screen, I only see results in the facets for Issues (the default result type). If I click on other search types, their result counts show up and then all the others are zero (including issues):

Steps to reproduce

1. Run a text search from the command palette/global search modal
2. Click on any facet and see that its count displays when selected but not when it's no longer selected

What is the current bug behavior?

See GIF in summary section

What is the expected correct behavior?

Facets should be populated with results when a search term is entered, even if they aren't selected

Relevant logs and/or screenshots

See GIF in Summary

Possible fixes

changed milestone to %Backlog

added groupglobal search typebug workflowsolution validation labels

added devopsdata stores sectioncore platform labels

assigned to @changzhengliu

I can see the count requests were sent out and responses were returned, but somehow the counters were not updated in other tabs.

@tbulva, could you take a look at the front-end logic? Thanks.

There is definitively some sort of regression, it looks like the super_sidebar api has changed. The old menu works fine. I will submit a fix for review shortly.

I traced this regression to this MR !133495 (merged). I talked to @dstull and we devised a solution.

@tbulva @dstull, thank you both for the quick action!

assigned to @tbulva

created branch 428246-unselected-advanced-search-facets-not-loading-after-search-term-entered to address this issue

mentioned in merge request !134401 (merged)

changed milestone to %16.6

unassigned @changzhengliu

added workflowin dev label and removed workflowsolution validation label

mentioned in issue #428655 (closed)

added Deliverable label

Setting health status to on track as the milestone has just begun.

Issue participants are welcome to override this by setting the health status to another value.

changed health status to on track

mentioned in commit 739ae1a6

mentioned in merge request !134641 (merged)

mentioned in commit b5f7224f

closed

added workflowcomplete label and removed workflowin dev label

mentioned in issue #429219 (closed)

marked #429219 (closed) as a duplicate of this issue

marked this issue as related to #429219 (closed)

mentioned in issue #430115 (closed)

marked #430115 (closed) as a duplicate of this issue

marked this issue as related to #430115 (closed)

Just commenting to give some feedback - and maybe helping to surface this issue on relevant web searches!

As minor as this UI bug might appear - as someone who is operating and also supporting very small to "medium" size GitLab instances for ~8 years (currently ~175 with Premium licensing), I've never had so many support requests for a singular issue before this one :) After getting some "Advanced Search is not working!" tickets, we tried to recreate & reindex our Elastic, which didn't help this time. It's really not a big issue, we can point people to the old navigation, or to this bug - ur just wait a couple of weeks.

If there happens to be another patch release before 16.6 and this can be included, I would be very thankful ^.^ And looking at the amount of duplicates, I guess I'd not be the only one.

In any case, thanks for your awesome work, can't wait to see this bug fix being rolled out, and looking forward to every new release!

@metabytewien, thank you for the feedback. We also discussed that we would want to review our bugfixes in the future and identify the backports. We just missed the backport window to 16.5 for this one, but the good news is that GitLab 16.6 is planned to be released on 11/16.

@changzhengliu I have made a docs MR to add this regression to the version 16.5 notes.

Thanks Marcus for highlighting the impact of the regression!

@alvin, thank you for keeping our doc updated!

mentioned in merge request !137500 (merged)

marked #434055 (closed) as a duplicate of this issue

marked this issue as related to #434055 (closed)

mentioned in issue #434055 (closed)

added 1 deleted label