Request changes quick action

added to epic &11719

@phikai, Please add a group or category label to identify issue ownership.

You can refer to the Features by Group handbook page for guidance.

If you are unsure about the correct group, please do not leave the issue without a group label, and refer to GitLab's shared responsibility functionality guidelines for more information on how to triage this kind of issue.

This message was generated automatically. You're welcome to improve it.

changed the description

changed milestone to %16.6

added devopscreate direction featureenhancement groupcode review sectiondev typefeature labels

changed the description

@phikai let me know if this requires design or if this is more of an exercise for @aqualls

@aqualls this will be a quick action for this dialog

@mnearents We should be fine without any designs here, I think the team will know what to do and can loop @aqualls in on the MR.

@mnearents Would you be able to explain how you see this quick action working? Is it meant to be used like /submit_review request_changes or is it its own quick action?

I think currently we have:

/submit_review
/approve

So I think having a distinct action here for /request_changes aligns with our current setup. Although I do like the idea of tying those both up in the /submit_review <action> concept... maybe that's a future iteration?

@iamphill @phikai We could do something like:

/request_changes
/approve
/submit_review (submit without explicit approval)

but I worry people will see submit_review and not know that is only 1 of 3 ways to submit a review. Whereas if we had

/submit_review_request_changes
/submit_review_approve
/submit_review

it might make more sense/be more discoverable. But those are really long to type too.

/submit_review <action> would be awesome

I'm happy to go with whatever makes sense. I can try figure out /submit_review <action> if that is the route we want eventually?

@iamphill I think we stick to boring for now and just use /request_changes. Can you create a follow up issue for improving the /submit_review... by adding an <action>?