Backend: Match Ci::BuildNeed name limit with job name limit
Summary
At the moment, no pipelines are created without any notifications of what could have gone wrong when these conditions are met:
- There is a
needs
relations between two jobs - The parent job has a matrix (a parallel job)
- The total number of characters of the expanded parent job name exceeds 128.
Proposal
The proposal here is to increase Ci::BuildNeed
's name limit to 255
(which matches the job
name limit).
NOTE: Since the ci_build_needs.name
column is already TEXT, the only thing that needs to be updated is the value of the MAX_JOB_NAME_LENGTH
constant from 128
to 255
.
Additional details
Some relevant technical details, if applicable, such as:
- Does this need a feature flag?
- Does there need to be an associated instrumentation issue created related to this work?
- Is there an example response showing the data structure that should be returned (new endpoints only)?
- What permissions should be used?
- Is this EE or CE?
-
EE -
CE
-
- Additional comments:
Implementation Table
Links/References
Edited by Mark Nuzzo