Add shared examples for `admin mode` to ee geo test
We need to adjusts test to fit the new feature admin mode for api
or how I call it api admin mode
.
We have two tasks to improve the tests. Firstly, we need to add admin_mode: true
to all API calls made by an admin. This has already been done in several merge requests.
Secondly, we need to add the shared examples explained in 'how to improve' as shown in this example merge request !116339 (merged). The second part is almost complete and lacks only a few tests. To improve those tests, one will need the correct configuration on the local setup. It would be greatly appreciated if someone could add the shared examples to the tests mentioned below, so that I can avoid having to make complicated settings for a small piece of code.
./ee/spec/requests/api/geo_nodes_spec.rb
./ee/spec/requests/api/geo_replication_spec.rb
./ee/spec/requests/api/geo_spec.rb
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Author Contributor
Collapse replies - Maintainer
How can I help?
- Author Contributor
I assume that you have set up the geo configurations since you reviewed them on !114791 (merged). It would be highly appreciated if you, or someone else who has the configurations set up, could create the missing tests for the missing tests mentioned above.
- Maintainer
Since these tests are part of "geo_replication" feature category and belong to the groupgeo, let's try to set proper labels to get some help.
@juan-silva could you give us a hand here?
- Developer
Thanks for flagging this. I will ask the team to review and assess effort as a first step.
1 - Maintainer
I estimate this a 2 since I believe the shared examples to be added to Geo specs are expected to pass as-is.
Edited by Michael Kozono - Developer
Thanks Mike. I am adding this for the next iteration. @sranasinghe FYI.
1
- Maintainer
Hey @TrueKalix, thank you for creating this issue!
To get the right eyes on your issue more quickly, we encourage you to follow the issue triage best practices.
PLEASE NOTE: You will need to use the
@gitlab-bot label command
to apply labels to this issue.To set expectations, GitLab product managers or team members can't make any promise if they will proceed with this. However, we believe everyone can contribute, and welcome you to work on this proposed change, feature or bug fix. There is a bias for action, so you don't need to wait. Try and spin up that merge request yourself.
If you need help doing so, we're always open to mentor you to drive this change.
This message was generated automatically. You're welcome to improve it.
- 🤖 GitLab Bot 🤖 added automation:self-triage-encouraged label
added automation:self-triage-encouraged label
- Contributor
This issue was automatically tagged with the label ~"group::purchase" by TanukiStan, a machine learning classification model, with a probability of 0.94.
If this label is incorrect, please tag this issue with the correct group label as well as automation:ml wrong to help TanukiStan learn from its mistakes.
If you are unsure about the correct group, please do not leave the issue without a group label. Please refer to GitLab's shared responsibility functionality guidelines for more information on how to triage this kind of issues.
Authors who do not have permission to update labels can leave the issue to be triaged by group leaders initially assigned by TanukiStan
This message was generated automatically. You're welcome to improve it.
- A deleted user added automation:ml grouppurchase [DEPRECATED] labels
added automation:ml grouppurchase [DEPRECATED] labels
- 🤖 GitLab Bot 🤖 added devopsfulfillment sectionfulfillment labels
added devopsfulfillment sectionfulfillment labels
- Vitali Tatarintev added backend devopssystems groupgeo maintenancetest-gap sectioncore platform test typemaintenance labels and removed devopsfulfillment grouppurchase [DEPRECATED] sectionfulfillment labels
added backend devopssystems groupgeo maintenancetest-gap sectioncore platform test typemaintenance labels and removed devopsfulfillment grouppurchase [DEPRECATED] sectionfulfillment labels
- Juan Silva added automation:ml wrong label
added automation:ml wrong label
- Michael Kozono set weight to 2
set weight to 2
- Juan Silva changed milestone to %16.1
changed milestone to %16.1
- Juan Silva added 1 deleted label
added 1 deleted label
- Juan Silva added workflowready for development label
added workflowready for development label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#12231 (closed)
mentioned in issue gitlab-org/quality/triage-reports#12231 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#12360 (closed)
mentioned in issue gitlab-org/quality/triage-reports#12360 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#12432 (closed)
mentioned in issue gitlab-org/quality/triage-reports#12432 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#12496 (closed)
mentioned in issue gitlab-org/quality/triage-reports#12496 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#12590 (closed)
mentioned in issue gitlab-org/quality/triage-reports#12590 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#12699 (closed)
mentioned in issue gitlab-org/quality/triage-reports#12699 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#12791 (closed)
mentioned in issue gitlab-org/quality/triage-reports#12791 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#12864 (closed)
mentioned in issue gitlab-org/quality/triage-reports#12864 (closed)
- 🤖 GitLab Bot 🤖 changed milestone to %16.2
changed milestone to %16.2
- 🤖 GitLab Bot 🤖 added missed:16.1 label
added missed:16.1 label
- Ghost User mentioned in issue gl-retrospectives/geo#49
mentioned in issue gl-retrospectives/geo#49
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#13028 (closed)
mentioned in issue gitlab-org/quality/triage-reports#13028 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#13165 (closed)
mentioned in issue gitlab-org/quality/triage-reports#13165 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#13259 (closed)
mentioned in issue gitlab-org/quality/triage-reports#13259 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#13328 (closed)
mentioned in issue gitlab-org/quality/triage-reports#13328 (closed)
- 🤖 GitLab Bot 🤖 changed milestone to %16.3
changed milestone to %16.3
- 🤖 GitLab Bot 🤖 added missed:16.2 label
added missed:16.2 label
- Ghost User mentioned in issue gl-retrospectives/geo#50
mentioned in issue gl-retrospectives/geo#50
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#13424 (closed)
mentioned in issue gitlab-org/quality/triage-reports#13424 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#13488 (closed)
mentioned in issue gitlab-org/quality/triage-reports#13488 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#13606 (closed)
mentioned in issue gitlab-org/quality/triage-reports#13606 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#13703 (closed)
mentioned in issue gitlab-org/quality/triage-reports#13703 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#13768 (closed)
mentioned in issue gitlab-org/quality/triage-reports#13768 (closed)
- 🤖 GitLab Bot 🤖 changed milestone to %16.4
changed milestone to %16.4
- 🤖 GitLab Bot 🤖 added missed:16.3 label
added missed:16.3 label
- Ghost User mentioned in issue gl-retrospectives/geo#51
mentioned in issue gl-retrospectives/geo#51
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#13860 (closed)
mentioned in issue gitlab-org/quality/triage-reports#13860 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#13979 (closed)
mentioned in issue gitlab-org/quality/triage-reports#13979 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14077 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14077 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14146 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14146 (closed)
- 🤖 GitLab Bot 🤖 changed milestone to %16.5
changed milestone to %16.5
- 🤖 GitLab Bot 🤖 added missed:16.4 label
added missed:16.4 label
- Ghost User mentioned in issue gl-retrospectives/geo#52
mentioned in issue gl-retrospectives/geo#52
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14240 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14240 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14354 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14354 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14446 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14446 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14517 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14517 (closed)
- 🤖 GitLab Bot 🤖 changed milestone to %16.6
changed milestone to %16.6
- 🤖 GitLab Bot 🤖 added missed:16.5 label
added missed:16.5 label
- Ghost User mentioned in issue gl-retrospectives/geo#53
mentioned in issue gl-retrospectives/geo#53
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14612 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14612 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14678 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14678 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14796 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14796 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14892 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14892 (closed)
- 🤖 GitLab Bot 🤖 changed milestone to %16.7
changed milestone to %16.7
- 🤖 GitLab Bot 🤖 added missed:16.6 label
added missed:16.6 label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14962 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14962 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#15058 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15058 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#15172 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15172 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#15267 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15267 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#15387 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15387 (closed)
- 🤖 GitLab Bot 🤖 changed milestone to %16.8
changed milestone to %16.8
- 🤖 GitLab Bot 🤖 added missed:16.7 label
added missed:16.7 label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#15483 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15483 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#15550 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15550 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#15691 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15691 (closed)
- 🤖 GitLab Bot 🤖 changed milestone to %16.9
changed milestone to %16.9
- 🤖 GitLab Bot 🤖 added missed:16.8 label
added missed:16.8 label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#15815 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15815 (closed)
- Juan Silva removed milestone %16.9
removed milestone %16.9