Skip to content

A more intuitive syntax for defining sections in CODEOWNERS for which approval is optional: [0] instead of ^

Background

Currently, approval for codeowner sections can be made optional by prepending ^ to the section heading: https://docs.gitlab.com/ee/user/project/code_owners.html#make-a-code-owners-section-optional

The new feature for requiring multiple approvals per CODEOWNER Section works by appending [n] to the end of a section to require n reviewers. n must be n ≥ 1 where [1] is optional as the default setting. Other values for n are invalid and the default setting n = 1 will be applied.

Problems

  • ^ isn't a very intuitive sign of the section being optional
  • Appending [0] for an optional review would be very intuitive
  • It is unclear what a section would do that has ^ prepended AND [2] appended

Links

This is issue is to follow-up on this discussion

Edited by Torsten Linz