Track Clusters::Applications job code removal
Related Issues:
- Remove clusters_applications_* code (#366573 - closed)
- Clarify Sidekiq Job Class and Jobs Removal Proc... (#377742 - closed)
Supporting MR for job instance removal: Resolve "Create a method to for Job Class insta... (!101576 - merged)
Jobs housed in app/workers/clusters/applications
Some work has already been done in MRs:
- Remove code around Clusters::Applications::Wait... (!101229 - merged)
- Begin removal of Clusters::Applications::Uninst... (!100333 - merged)
The remaining initial work to be done around jobs involves figuring out a solution for dealing with:
-
app/workers/clusters/applications/activate_integration_worker.rb
- the issue is that it is invoked in
app/models/clusters/integrations/prometheus.rb
which is not part of this deprecation
- the issue is that it is invoked in
-
app/workers/clusters/applications/deactivate_integration_worker.rb
- the iss is that it is is invoked in
app/models/clusters/integrations/prometheus.rb
which is not part of this deprecation
- the iss is that it is is invoked in
See #379014 (comment 1150149434) comment for thoughts on that.
Jobs housed directly in app/workers/
- investigate all the related job code that is housed in
app/workers/
and not namespaced specifically asClusters::Applications
. I have listed them all below.
These are all the ones I need to check that are just in app/workers
- cluster_configure_istio_worker.rb
- cluster_install_app_worker.rb
- cluster_patch_app_worker.rb
- cluster_provision_worker.rb
- cluster_update_app_worker.rb
- cluster_upgrade_app_worker.rb
- cluster_wait_for_app_installation_worker.rb
- cluster_wait_for_app_update_worker.rb
- cluster_wait_for_ingress_ip_address_worker.rb
I used Rg ClassNameAsFoundInFile --files-with-matches
to grep for this information.
✅ ClusterConfigureIstioWorker
MR
Deprecate worker, delete single use service (!102225 - merged)
class definition
app/workers/cluster_configure_istio_worker.rb
specs
- spec/workers/cluster_configure_istio_worker_spec.rb
- spec/workers/every_sidekiq_worker_spec.rb
- spec/models/clusters/applications/knative_spec.rb
invocations
- app/workers/all_queues.yml
- app/models/clusters/applications/knative.rb
ClusterInstallAppWorker
MR
Delete Clusters::Applications::CreateService files (!102324 - merged)
class definition
app/workers/cluster_install_app_worker.rb
specs
- spec/services/clusters/applications/create_service_spec.rb
- spec/workers/every_sidekiq_worker_spec.rb
invocations
- app/services/clusters/applications/create_service.rb
- app/workers/all_queues.yml
ClusterPatchAppWorker
MR
Delete PatchService and spec (!102334 - merged)
class definition
app/workers/cluster_patch_app_worker.rb
specs
- spec/services/clusters/applications/update_service_spec.rb
- spec/workers/every_sidekiq_worker_spec.rb
invocations
- app/services/clusters/applications/update_service.rb
- app/workers/all_queues.yml
✅ ClusterProvisionWorker
Clusters::Applications
deprecation. This class and its invocations should not be deprecated/removed/changed.
class definition
app/workers/cluster_provision_worker.rb
specs
- spec/services/clusters/create_service_spec.rb
- spec/controllers/admin/clusters_controller_spec.rb
- spec/controllers/groups/clusters_controller_spec.rb
- spec/controllers/projects/clusters_controller_spec.rb
- spec/workers/cluster_provision_worker_spec.rb
- spec/workers/every_sidekiq_worker_spec.rb
- spec/support/services/clusters/create_service_shared.rb
invocations
- app/services/clusters/create_service.rb
- app/workers/all_queues.yml
ClusterUpdateAppWorker
This class's invocations appear to have already been removed. We can go ahead and noop the job to further prepare for removal.
MR
Deprecate ClusterUpdateAppWorker, delete unused... (!102662 - merged)
class definition
app/workers/cluster_update_app_worker.rb
specs
- spec/workers/every_sidekiq_worker_spec.rb
- spec/workers/cluster_update_app_worker_spec.rb
invocations
- app/workers/all_queues.yml
ClusterUpgradeAppWorker
MR
NOOP'd here: Delete Clusters::Applications::CreateService files (!102324 - merged) but still take another look at this one to see if any other code around this can be removed.
class definition
app/workers/cluster_upgrade_app_worker.rb
specs
- spec/services/clusters/applications/create_service_spec.rb
- spec/workers/every_sidekiq_worker_spec.rb
invocations
- app/services/clusters/applications/create_service.rb
- app/workers/all_queues.yml
ClusterWaitForAppInstallationWorker
MR
Deprecate job and remove unused service (!102895 - merged)
class definition
app/workers/cluster_wait_for_app_installation_worker.rb
specs
- spec/services/clusters/applications/check_installation_progress_service_spec.rb
- spec/services/clusters/applications/install_service_spec.rb
- spec/services/clusters/applications/patch_service_spec.rb
- spec/services/clusters/applications/upgrade_service_spec.rb
- spec/workers/every_sidekiq_worker_spec.rb
- spec/factories/clusters/applications/helm.rb
invocations
- app/services/clusters/applications/install_service.rb
- app/services/clusters/applications/check_installation_progress_service.rb
- app/services/clusters/applications/upgrade_service.rb
- app/services/clusters/applications/patch_service.rb
- app/workers/all_queues.yml
ClusterWaitForAppUpdateWorker
MR
Noop job and delete unused service (!102913 - merged)
class definition
app/workers/cluster_wait_for_app_update_worker.rb
specs
- spec/services/clusters/applications/check_upgrade_progress_service_spec.rb
- spec/services/clusters/applications/prometheus_update_service_spec.rb
- spec/workers/cluster_wait_for_app_update_worker_spec.rb
- spec/workers/every_sidekiq_worker_spec.rb
invocations
- app/services/clusters/applications/check_upgrade_progress_service.rb
- app/services/clusters/applications/prometheus_update_service.rb
- app/workers/all_queues.yml
ClusterWaitForIngressIpAddressWorker
MR
Noop worker class and delete unused service (!102925 - merged)
class definition
app/workers/cluster_wait_for_ingress_ip_address_worker.rb
specs
- spec/workers/cluster_wait_for_ingress_ip_address_worker_spec.rb
- spec/workers/every_sidekiq_worker_spec.rb
- spec/models/clusters/applications/ingress_spec.rb
- spec/models/clusters/applications/knative_spec.rb
invocations
- app/workers/all_queues.yml
- app/models/clusters/applications/ingress.rb
- app/models/clusters/applications/knative.rb