Delete Clusters::Applications::CreateService files
What does this MR do and why?
Per Remove clusters_applications_* code (#366573 - closed) we are removing code around Clusters::Applications.
This MR
- Writes a deprecation note in ClusterInstallAppWorker.
- Noops the perform method for the ClusterInstallAppWorker.
- Deletes the Clusters::Applications::CreateService as it is only invoked by ClusterInstallAppWorker but this MR removes that invocation, leaving it unused.
- Deletes the unit specs for the service class (I couldn't find a unit spec for the Worker class)
NOTE: I grepped for usage of this namespaced service as Clusters::Applications::CreateService
and didn't see usage. Then I grepped for CreateService
within any applications/clusters/
files incase there was non fully qualified namespace usage within scope. The only thing I found in that search uses :: to go to the top level namespace which references a different service.
➜ gitlab git:(hustewart-remove-cluster-install) Rg CreateService --files-with-matches -g '**/clusters/applications/**'
app/services/clusters/applications/base_service.rb
And I double checked that after this commit is applied there are no more references to the fully qualified namespace:
➜ gitlab git:(hustewart-remove-cluster-install) Rg Clusters::Applications::CreateService --files-with-matches
I'm holding off on deleting the Clusters::Applications::InstallService
because it appears in some documentation and it would slow down this MR quite a bit for me to navigate that. I have added a tracking issue for that here: Track Clusters::Applications documentation updates (#379146 - closed)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.