Add application size validations for ci_builds columns

We have a few columns in the ci_builds table with type varchar 255, but we don't have any model validations for them. We should add validations to match, but this is a breaking change for self-managed because there is no limit at the column level for new installs: #321685

• status
• stage
• ref
• type
• target_url
• description

This validation must be implemented under a feature flag called ci_builds_columns_size_validation.

added breaking change devopsverify grouppipeline execution typemaintenance labels

added sectionops label

changed milestone to %16.0

marked this issue as blocking #321685

changed the description

mentioned in issue #321685

added [deprecated] Accepting merge requests label

Or maybe we could do it sooner if the validations are limited to .com only and in %16.0 made generally available.

@mbobin we should be able to release this behind a feature flag toggled off by default sooner and remove it in 16.0 as a breaking change what I don't know is if we can ship it a few milestones before that toggled on by default for new installs only vs. upgrades. @grzesiek may have some insights.

We can probably release this on GitLab.com sooner (as on GitLab.com it would not be a breaking change, since you can't store longer data anyways today), and then enable by default in 16.0, right?

Yes, I think it would work.

@mbobin @shampton @carolinesimpson is this still something we think we can deliver with 16.0 for Self Managed users? If so we need to create a deprecation notice this week. Thanks!

@jheimbuck_gl I will defer to @mbobin as he has the most knowledge about an issues that we could run into with this. If he thinks it is fine to go forward with this, then I think we should do it.

@jheimbuck_gl @carolinesimpson I think it should be fine for all of the fields, except name because that one might break a lot of pipelines for parallel:matrix users since we append the variables to the job name: #362262 (closed)

thanks @mbobin yeah we would break even more of those than we do already today. Can we remove that from the validation for now? what tradeoffs in performance would we make if we do that?

@jheimbuck_gl we're not doing this for performance reasons since we can't have fields with length greater than 255 on .com. We're doing it for consistency, to have the same sizes everywhere so that we don't develop future features/optimizations with wrong assumptions.

We should remove name from the validation/deprecation notice because it will likely break new pipelines that use parallel:matrix with a a lot of variables since it's easy to go over the limit in that case and we don't have a good alternative for it: #362262 (closed)

thanks @mbobin i'll update the deprecation notice!

marked #300460 (closed) as a duplicate of this issue

marked this issue as related to #300460 (closed)

marked this issue as related to #327182

mentioned in issue #300460 (closed)

added Category:Continuous Integration label

added Track Health Status [DEPRECATED] label

mentioned in merge request gitlab-foss!33166 (closed)

changed the description

mentioned in merge request !112280 (merged)

added Deliverable label

mentioned in issue gitlab-com/gl-infra/delivery#2916 (closed)