Remove deprecated Container Scanning variables with Docker references
All Container Scanning variables that are prefixed by
DOCKER_
in variable name are deprecated. This includes theDOCKER_IMAGE
,DOCKER_PASSWORD
,DOCKER_USER
, andDOCKERFILE_PATH
variables. Support for these variables will be removed in the GitLab 16.0 release. Use the new variable namesCS_IMAGE
,CS_REGISTRY_PASSWORD
,CS_REGISTRY_USER
, andCS_DOCKERFILE_PATH
in place of the deprecated names.
As the DOCKER_{IMAGE,USER,...}
variables were deprecated (#357264 (closed)), we now need to remove them.
See:
Implementation plan
-
backend Remove support for
DOCKER_{IMAGE,USER,...}
variables incontainer-scanning
analyzer -
documentation Remove information about supported
DOCKER_{IMAGE,USER,...}
variables
Verification steps
-
Create a new pipeline which references the
registry.gitlab.com/security-products/container-scanning:6
image and confirm that theCS_IMAGE
var works, while theDOCKER_IMAGE
var no longer works.See Verification steps for more details.
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Dominic Bauer changed milestone to %16.0
changed milestone to %16.0
- Dominic Bauer added devopsgovern groupsecurity policies sectionsec labels
added devopsgovern groupsecurity policies sectionsec labels
- Dominic Bauer mentioned in merge request gitlab-org/security-products/analyzers/container-scanning!2806 (merged)
mentioned in merge request gitlab-org/security-products/analyzers/container-scanning!2806 (merged)
- Thiago Figueiró added backend deprecation workflowrefinement labels
added backend deprecation workflowrefinement labels
- Developer
FYI, @sam.white - I think we'll need a deprecation release post for this.
Collapse replies - Developer
Link for docs: !96172 (diffs)
- Contributor
Thanks for the heads up @thiagocsf. I just opened !97561 (merged) for this.
1
- Maintainer
@mparuszewski, could you please refine this issue?
- 🤖 GitLab Bot 🤖 assigned to @mparuszewski
assigned to @mparuszewski
- Alan (Maciej) Paruszewski changed the description
Compare with previous version changed the description
- Alan (Maciej) Paruszewski added workflowready for development label and removed workflowrefinement label
added workflowready for development label and removed workflowrefinement label
- Alan (Maciej) Paruszewski set weight to 1
set weight to 1
- Alan (Maciej) Paruszewski unassigned @mparuszewski
unassigned @mparuszewski
- Maintainer
@mparuszewski, thanks for adding the workflowready for development label.
This issue has been sent back to workflowrefinement because it's missing the work type classification.
Please add a
type::
label and try again.This message was generated automatically. You're welcome to improve it.
- 🤖 GitLab Bot 🤖 added workflowrefinement label and removed workflowready for development label
added workflowrefinement label and removed workflowready for development label
- Alan (Maciej) Paruszewski added maintenanceremoval typefeature labels
added maintenanceremoval typefeature labels
- Alan (Maciej) Paruszewski added workflowready for development label and removed workflowrefinement label
added workflowready for development label and removed workflowrefinement label
- 🤖 GitLab Bot 🤖 added [deprecated] Accepting merge requests label
added [deprecated] Accepting merge requests label
- Maintainer
Setting label(s) Category:Security Policy Management based on groupsecurity policies.
- 🤖 GitLab Bot 🤖 added Category:Security Policy Management label
added Category:Security Policy Management label
- Sam White mentioned in merge request !97561 (merged)
mentioned in merge request !97561 (merged)
- Alan (Maciej) Paruszewski added Category:Container Scanning devopssecure groupcomposition analysis labels and removed devopsgovern groupsecurity policies labels
added Category:Container Scanning devopssecure groupcomposition analysis labels and removed devopsgovern groupsecurity policies labels
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#10046 (closed)
mentioned in issue gitlab-org/quality/triage-reports#10046 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#10145 (closed)
mentioned in issue gitlab-org/quality/triage-reports#10145 (closed)
- Will Meek added quad-planningcomplete-no-action label
added quad-planningcomplete-no-action label
- Brian Rhea added typemaintenance label and removed typefeature label
added typemaintenance label and removed typefeature label
- Maintainer
You may have noticed that typefeature was replaced with typemaintenance and the ~"feature::removal" label was renamed to maintenanceremoval. In short, this recategorization is more fitting for removals, but you can learn more here: gitlab-com/www-gitlab-com!108820 (merged). - Sam White added to epic &9609 (closed)
added to epic &9609 (closed)
- Olivier Gonzalez set weight to 2
set weight to 2
- Sam White changed the description
Compare with previous version changed the description
- Developer
@sam.white We are working to coordinate the 16.0 major release rollout on GitLab.com. In order to keep customer impact minimal, it would be ideal to deploy the breaking changes behind feature flags.
This will allow us to decouple feature deployment from feature activation on GitLab.com and thus announce a more accurate time period when breaking changes go live.
We currently don't have the information if this feature can be deployed behind a feature flag. Please add that information (if there is a feature flag and how is it called) here.
For more information refer to this issue
@swiskow for visibility
This is an automated message.
Collapse replies - Contributor
@mbruemmer I don't believe we can deploy this behind a feature flag as the code changes are in the container scanning project.
2
- Olivier Gonzalez added Deliverable label
added Deliverable label
- Lyle Kozloff mentioned in epic gitlab-com/support&271
mentioned in epic gitlab-com/support&271
- Maintainer
Setting health status to
on track
as the milestone has just begun.Issue participants are welcome to override this by setting the health status to another value.
- 🤖 GitLab Bot 🤖 changed health status to on track
changed health status to on track
- Aditya Tiwari assigned to @atiwari71
assigned to @atiwari71
- Adam Cohen added workflowin dev label and removed workflowready for development label
added workflowin dev label and removed workflowready for development label
- Aditya Tiwari marked the checklist item backend Remove support for
DOCKER_{IMAGE,USER,...}
variables incontainer-scanning
analyzer as completedmarked the checklist item backend Remove support for
DOCKER_{IMAGE,USER,...}
variables incontainer-scanning
analyzer as completed - Aditya Tiwari marked the checklist item backend Remove support for
DOCKER_{IMAGE,USER,...}
variables incontainer-scanning
analyzer as incompletemarked the checklist item backend Remove support for
DOCKER_{IMAGE,USER,...}
variables incontainer-scanning
analyzer as incomplete - Aditya Tiwari added workflowin review label and removed workflowin dev label
added workflowin review label and removed workflowin dev label
- Adam Cohen mentioned in merge request gitlab-org/security-products/analyzers/container-scanning!2876 (merged)
mentioned in merge request gitlab-org/security-products/analyzers/container-scanning!2876 (merged)
- Aditya Tiwari marked the checklist item backend Remove support for
DOCKER_{IMAGE,USER,...}
variables incontainer-scanning
analyzer as completedmarked the checklist item backend Remove support for
DOCKER_{IMAGE,USER,...}
variables incontainer-scanning
analyzer as completed - Aditya Tiwari marked the checklist item documentation Remove information about supported
DOCKER_{IMAGE,USER,...}
variables as completedmarked the checklist item documentation Remove information about supported
DOCKER_{IMAGE,USER,...}
variables as completed - Aditya Tiwari closed
closed
- Aditya Tiwari added workflowcomplete label and removed workflowin review label
added workflowcomplete label and removed workflowin review label
- Olivier Gonzalez reopened
reopened
- Developer
@atiwari71 I'm reopening this issue as we need to publish this change under the next major rather than the current one to avoid deploying the breaking change to existing users using GitLab 15.x.
I've started the revert in gitlab-org/security-products/analyzers/container-scanning!2879 (merged)
Collapse replies - Maintainer
@gonzoyumo To unblock this, I have created a branch
v6.x
and raised this MR against thev6.x
branch.Edited by Aditya Tiwari
- Olivier Gonzalez added workflowin dev label and removed workflowcomplete label
added workflowin dev label and removed workflowcomplete label
- Aditya Tiwari mentioned in merge request gitlab-org/security-products/analyzers/container-scanning!2881 (merged)
mentioned in merge request gitlab-org/security-products/analyzers/container-scanning!2881 (merged)
- Adam Cohen mentioned in issue #408803 (closed)
mentioned in issue #408803 (closed)
- Olivier Gonzalez added workflowverification label and removed workflowin dev label
added workflowverification label and removed workflowin dev label
- Maintainer
I see that this is now going through the workflowverification phase but I don't see any
Verification steps
section in the issue. How is this tested? Collapse replies - Developer
There are Verification steps in the issue Release Container Scanning v6 (#408803 - closed). I'll add a link to the description.
- Adam Cohen changed the description
Compare with previous version changed the description
- Developer
Sounds like this was released and tested with #408803 (comment 1386532926) so closing the issue.
1 - Olivier Gonzalez closed
closed
- Olivier Gonzalez added closedcomplete workflowcomplete labels and removed workflowverification label
added closedcomplete workflowcomplete labels and removed workflowverification label
- Maintainer
@gonzoyumo, the workflow label was automatically updated to workflowcomplete because you closed the issue while in workflowverification.
If this is not the correct label, please update.
To avoid this message, update the workflow label as you close the issue.
1 - Olivier Gonzalez mentioned in merge request !120657 (merged)
mentioned in merge request !120657 (merged)