Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 43,790
    • Issues 43,790
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,418
    • Merge requests 1,418
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Issues
  • #350730
Closed
Open
Created Jan 20, 2022 by Pedro Pombeiro@pedropombeiroDeveloper3 of 3 tasks completed3/3 tasks

Rename Runner model and API maintainer_note field to maintenance_note

Summary

Based on the discussion in gitlab-runner!3268 (comment 815663628) it emerged that the new maintainer_note field name (also released in a REST API in %14.7 through !77779 (merged)) was not a good name for several reasons, namely because 'maintainer' is the name of a role, which does not necessarily need to match the role in which this field is used, and there is already an instance of a maintainer_note in our code which is related to the Note model.

Implementation

  1. Create an alias in the Ci::Runner model;
  2. Accept the new maintenance_note field in the REST API in addition to maintainer_note. Convert maintainer_note to maintenance_note upon reception;
  3. Mark the maintenance_note field in the REST API as deprecated.

Links

  • gitlab-foss#47592 (comment 80050827)
  • follow-up Rename ci_runners.maintainer_note -> ci_runners... (#351089)
Edited Jan 25, 2022 by Pedro Pombeiro
Assignee
Assign to
Time tracking