Skip to content

Allow specifying maintenance-note on runner registration

Pedro Pombeiro (OOO from July 16th till Aug 7th) requested to merge pedropombeiro/348299/3-add-notes-support-on-register into main

What does this MR do?

This MR builds on Accept maintainer_note parameter in REST runner... (gitlab!77779 - merged).

Why was this MR needed?

It allows the user to specify administrative notes to be associated with a newly registered runner.

What's the best way to test this MR?

Run the gitlab!77779 (merged) branch on the local GDK and issue the following command on this branch:

gitlab-runner register \
        --non-interactive \
        --executor "shell" \
        --url "http://gdk.localhost:3000/" \
        --description "Instance audit log test runner" \
        --maintenance-note "Administrative notes" \
        --tag-list "shell,gdk,mac,test" \
        --run-untagged="false" \
        --locked="false" \
        --access-level="not_protected" \
        --registration-token="$TOKEN"

Then on the GDK console, issue the following:

> Ci::Runner.last.maintainer_note
  Ci::Runner Load (1.1ms)  SELECT "ci_runners".* FROM "ci_runners" ORDER BY "ci_runners"."id" DESC LIMIT 1 /*application:console,db_config_name:main,line:(pry):70:in `__pry__'*/
=> "Administrative notes"

What are the relevant issue numbers?

gitlab#348299 (closed)

Edited by Pedro Pombeiro (OOO from July 16th till Aug 7th)

Merge request reports