Accept maintainer_note parameter in REST runner registration
What does this MR do and why?
Describe in detail what your merge request does and why.
This MR adds support for taking in a maintainer_note
field in the runner registration endpoint. A gitlab/gitlab-runner
MR will soon take advantage from this addition so as to allow an admin to specify notes to be associated with the new runner.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Part of #348299 (closed)
Merge request reports
Activity
added api label
assigned to @pedropombeiro
changed milestone to %14.7
removed databasereview pending label
removed database-testing-automation label
removed database label
mentioned in issue #348299 (closed)
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/api/runners.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Vladlena Shumilo ( @vshumilo
) (UTC-5, 6 hours behind@pedropombeiro
)Nikola Milojevic ( @nmilojevic1
) (UTC+1, same timezone as@pedropombeiro
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in merge request gitlab-runner!3268 (merged)
- Resolved by Pedro Pombeiro
requested review from @tigerwnz
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
removed review request for @tigerwnz
@tigerwnz
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added 137 commits
- c5d75b4c - Remove log_implicit_sidekiq_status_calls feature flag
- 19435213 - Show number of counts next to tabs
- 9131bf42 - Allow setting Sidekiq status only when opted in
- c752c229 - Do not fail report ingestion if there is an invalid finding
- 49b672bb - Remove docs discouraging single-line conditionals
- fdd1fda8 - Update BG migration docs for removed methods
- ae92ac84 - Account for behavior on slow network condition
- 43d8a69c - Add GraphQL mutation to revoke an agent token
- de7db9d7 - Add Group Access Token API endpoints
- eff9a857 - Fix Kubernetes Agent Link on Project page
- 616cfcc6 - Remove deployments_archive feature flag
- 7360983d - Pass formats explicitly when rendering .md file
- ff5b66f0 - Remove feature flag optimize_merge_request_parser
- bcf1c4a3 - Update translation levels - Jan 2022
- ae62f567 - Move files from ~/ to more approprate modules
- 0fcc2387 - Adds new unchecked free indicator variant method
- 15c406cc - test: Configure Gitaly's bundler with env vars
- 8560c74f - test: Expand bundle path to absolute path
- 8137562c - test: Install Gitaly incrementally
- 62f8555e - test: Use GitalySetup to build Gitaly in test
- 08fc9756 - test: Move most of the Gitaly setup to GitalySetup
- f67778c0 - test: Move spawning of Gitaly to GitalySetup
- 52e46eb9 - test: Introduce GITALY_TEST_BUNDLE_PATH
- ceebd2d6 - Added Container Registry and Dependency Proxy
- 4de07933 - Add enable and disable advanced search rake tasks
- bcbfe792 - Remove a warning message from the agent repository doc
- 7b068a4d - Pass formats explicitly when rendering .md file
- e8826a3c - GitLab Version - Update Version Status Indicator
- 668cc33a - Remove foreign key ci_pending_builds.namespace_id
- d67b33e8 - Sort followed users events by id desc
- 758308cd - Merge branch '346435-fix-activities-followed-users-sort-order' into 'master'
- bfcd87d5 - Merge branch '348269-remove-ci_pending_builds-namespace_id-fk' into 'master'
- e91e8df9 - New translations gitlab.pot (Greek)
- 7b20b490 - Merge branch 'master-i18n' into 'master'
- ca29fd87 - Merge branch 'issue_32492_build_from_vulnerability_service' into 'master'
- 89e50706 - Set low custom apdex for Value Stream Analytics
- 20562617 - Merge branch 'cngo-tidy-javascript-root-directory' into 'master'
- 73a69995 - Prevent design discussions without login
- aea0661a - Add an initial version of the CI/CD time decay blueprint
- 12491bd1 - Describe three parallel workstreams for CI/CD time-decay
- 8276e756 - Add minor changes to the CI/CD time decay blueprint
- 9f1b0b30 - Reference CI/CD scaling blueprint in the summary
- 29074f7e - Copy-edit CI/CD time decay blueprint
- 191695f2 - Copy-edit CI/CD time decay blueprint
- 38d813b1 - Link to epics and resources from CI/CD time decay blueprint
- 57efe183 - Make it clear what is the goal of partitioning CI/CD data
- 4fd5ab16 - Visualize the three tracks in CI/CD time decay blueprint
- 6f763748 - Add a section about principles to CI/CD time decay blueprint
- 11fdf26d - Improve CI/CD time decay blueprint and add a disclaimer
- e099eb51 - Merge branch 'docs/gb/architecture/ci-partitioning' into 'master'
- a08ca0f8 - Merge branch 'djensen-set-custom-apdex-sli-for-value-stream-analytics' into 'master'
- 35b5cabe - Merge branch 'hdelalic-master-patch-01412' into 'master'
- 50d75c7f - Merge branch 'allow-disabling-sidekiq-status-when-not-opted-in' into 'master'
- 3db9ff8e - Update Pajamas badges on sherlock/transactions
- a57b802f - Remove unneeded variant option
- 06358164 - Added Storybook stories for shared survey Banner
- a749adf4 - Merge branch 'jnnkl-storybook-shared-survey-banner' into 'master'
- 538543c5 - Merge branch 'revoke-agent-token-mutation' into 'master'
- ef64328d - Refactor wiki_form_spec.js file
- 68d92ec2 - Merge branch 'update-badges-sherlock-transactions-pajamas' into 'master'
- e6c9839d - Merge branch 'fix-doc-agent-config-repo' into 'master'
- 442a9482 - Merge branch 'remove-deployments_archive-feature-flag' into 'master'
- c9d16fd4 - Remove outdated GitLab versions from Package docs
- 26fb603a - Merge branch '343055-update-docs-for-removed-methods' into 'master'
- 078e4e5e - Update gitaly to 3627c14a64c
- 013d87ac - Style and content edits for self-hosting docs
- e54e53f2 - Merge branch 'docs-self-host-docs-site-update' into 'master'
- a016abab - Refactor admin labels to use shared HAML partial
- a4845e93 - Merge branch '345195-add-a-delete-button-to-the-edit-label-pages' into 'master'
- d700de55 - Make ~/issues/show/constants consistent
- 65a33ca6 - Merge branch 'cngo-make-issues-show-constants-consistent' into 'master'
- 8272c8ce - Improve UI text of group webhooks page
- 770e4fd3 - Merge branch 'russell/improve-group-webhooks-uitext' into 'master'
- 35f6ccda - Merge branch 'release-tools/update-gitaly' into 'master'
- 6662fa41 - Merge branch '345910-refactor-wiki-form-spec' into 'master'
- 0f711b8b - Track the promote_mr_approvals_in_free experiment
- 22c50207 - Merge branch '224185-track-the-mr-approval-promo-experiment' into 'master'
- c6db9521 - Merge branch '267570-prevent-design-comments-without-signing-in' into 'master'
- 0aa5b237 - Remove migration helpers using BG migrations
- a4f56897 - Merge branch 'issue_342492_vulnerability_presenter' into 'master'
- c2facc9c - Remove outdated GitLab versions from Monitor docs
- d0093862 - Add package managers api paths to details type
- ac764452 - Merge branch '347409-migrate-package-details-page-to-vue-router-2' into 'master'
- 679823cc - Merge branch '295266_1_5-update-version-check' into 'master'
- 84dfb98e - Add ability to fetch number of tests a scenario would run
- 5d3cda04 - Merge branch 'qa-shl-return-no-of-examples-only' into 'master'
- 2e85fc86 - Merge branch 'toon-gitaly-test-setup' into 'master'
- 3d1d87de - Merge branch 'remove-incorrect-docs' into 'master'
- 6e55a60d - Merge branch...
- 66b1717d - Merge branch 'docs-monitor-gitlab-ver-rem' into 'master'
- a2bb950f - Merge branch 'pb-remove-bg-migration-schema-helpers' into 'master'
- c4d6756a - Merge branch 'docs-package-gitlab-ver-rem' into 'master'
- c9aa7e9f - Merge branch '338239-add-counts-to-vuln-tabs' into 'master'
- 93106449 - Merge branch '349610_dont_fail_store_report_service_for_invalid_reports' into 'master'
- e7254493 - Update details about pipeline visibility
- 8ad3d6eb - Merge branch 'docs-clarify-pipeline-visibility' into 'master'
- 3bc2e985 - Add troubleshooting section to Code Owners doc
- 3d35d146 - Merge branch 'docs-gerardo-master-patch-11398' into 'master'
- 3f7f3c95 - Update the loose foeign key documentation
- 4dbe58d3 - Merge branch 'euko-update-loose-foreign-key-doc' into 'master'
- 40f1a4b2 - Merge branch 'sselhorn-master-patch-42296' into 'master'
- b8eb9f1d - Add namespace_id reference to routes
- b1316e76 - Merge branch 'jprovazn-second-source-model' into 'master'
- 3ecdc804 - Add customer relations group setting
- 68dfa652 - Merge branch '346082-remove-customer-relations-ff' into 'master'
- 730a696a - Fix merge request capitalization
- a60ee444 - Update search badges to pajamas
- ffa85fad - Merge branch 'egb-add-es-toggle-rake' into 'master'
- dd2b75cf - Add overview of knapsack report generation
- 579e40de - Merge branch 'acunskis-knapsack-doc-update' into 'master'
- d19fcd3b - Updates tags API docs to reflect get repository tags defaults
- 86b385d9 - Merge branch 'websvc-master-patch-73616' into 'master'
- 1e7c3b52 - Merge branch 'feat/group-access-token-api' into 'master'
- 50ef0452 - Fix bulk edit unchecking in issues list refactor
- 60dc5d2c - Merge branch '349628-fix-bulk-edit-in-issues-list-refactor' into 'master'
- 2fb0a9fa - Improve UI text of external authentication
- 98ee5d63 - Merge branch 'russell/improve-external-auth-ui-text' into 'master'
- 3abadcad - Delete vue_issuables_list feature flag
- a387a751 - Merge branch 'cngo-delete-vue_issuables_list-ff' into 'master'
- 501ffc0f - Modify project.group_runners query
- 82253cc6 - Merge branch 'mo-fix-for-project-any_online_runners-generates-cross-database-query' into 'master'
- 41dffe1c - Add pagination to corpus management
- 2d124bc4 - Merge branch '345090-corpus-table-pagination' into 'master'
- 03b317b1 - Small improvements to MR API page
- 3e98649b - Merge branch 'aqualls-mr-api-fixes' into 'master'
- 8acbce17 - Fix and Refactor invite_group Method and Update invite_group_to_project_spec
- c9780a46 - Merge branch 'fix-e2e-invite-group-method' into 'master'
- 8fa4d3c1 - Merge branch '349358-wait-for-new-pipeline' into 'master'
- 47459726 - Merge branch '344320-update-search-badges-pajamas' into 'master'
- 28981f57 - Merge branch 'fix-ka-link-on-project' into 'master'
- 550a2feb - Merge branch 'docs-merge-request-cap' into 'master'
- 49c040ba - Add versioning and AWS link to OIDC
- 2d26ddb3 - Merge branch 'oidc_doc_updates' into 'master'
- 59d2232a - Merge branch '331893_remove_feature_flag' into 'master'
- 316dd826 - Add notes field to CI runners table
- a00b76a0 - Address MR review comments
- 8511ff62 - Accept notes parameter in REST runner registration
Toggle commit listrequested review from @jprovaznik
Allure report
allure-report-publisher
generated test report for 8511ff62!review-qa-smoke:
test report
review-qa-reliable: test report- Resolved by Pedro Pombeiro
- Resolved by Pedro Pombeiro
removed review request for @jprovaznik
added 3 commits
-
9e7aa92f...493838f8 - 2 commits from branch
pedropombeiro/348299/1-add-notes-field
- 5e0eb912 - Accept maintainer_note in REST runner registration
-
9e7aa92f...493838f8 - 2 commits from branch
added 202 commits
-
5e0eb912...ce603fbe - 201 commits from branch
pedropombeiro/348299/1-add-notes-field
- 131472dc - Accept maintainer_note in REST runner registration
-
5e0eb912...ce603fbe - 201 commits from branch
requested review from @jprovaznik
added 116 commits
-
131472dc...54f16dd7 - 115 commits from branch
master
- 574e6f6e - Accept maintainer_note in REST runner registration
-
131472dc...54f16dd7 - 115 commits from branch
- A deleted user
added documentation label
- Resolved by Jan Provaznik
Thanks @pedropombeiro, LGTM
. Approved. @sselhorn (as a tech writer for grouprunner ), could you please approve the minor documentation change?
requested review from @sselhorn and removed review request for @jprovaznik
added Technical Writing docsfeature labels
removed review request for @sselhorn
requested review from @jprovaznik
Thanks @pedropombeiro, MWPS set
enabled an automatic merge when the pipeline for 487bd339 succeeds
mentioned in commit 7924137d
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
Confirmed that this is working in production using gitlab-runner!3268 (merged) and checking the prod database.
added workflowverification label and removed workflowproduction label
mentioned in issue #350730 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!562 (merged)
mentioned in issue #351089