Skip to content
Snippets Groups Projects

Accept maintainer_note parameter in REST runner registration

Merged Pedro Pombeiro requested to merge pedropombeiro/348299/2-add-notes-param-in-rest-api into master
All threads resolved!

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR adds support for taking in a maintainer_note field in the runner registration endpoint. A gitlab/gitlab-runner MR will soon take advantage from this addition so as to allow an admin to specify notes to be associated with the new runner.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Part of #348299 (closed)

Edited by Pedro Pombeiro

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jan Provaznik removed review request for @jprovaznik

    removed review request for @jprovaznik

  • Pedro Pombeiro added 2 commits

    added 2 commits

    • 75f390f2 - 1 commit from branch pedropombeiro/348299/1-add-notes-field
    • 9e7aa92f - Accept maintainer_note in REST runner registration

    Compare with previous version

  • Pedro Pombeiro added 3 commits

    added 3 commits

    • 9e7aa92f...493838f8 - 2 commits from branch pedropombeiro/348299/1-add-notes-field
    • 5e0eb912 - Accept maintainer_note in REST runner registration

    Compare with previous version

  • Pedro Pombeiro changed title from Accept notes parameter in REST runner registration to Accept maintainer_note parameter in REST runner registration

    changed title from Accept notes parameter in REST runner registration to Accept maintainer_note parameter in REST runner registration

  • Pedro Pombeiro changed the description

    changed the description

  • Pedro Pombeiro added 202 commits

    added 202 commits

    • 5e0eb912...ce603fbe - 201 commits from branch pedropombeiro/348299/1-add-notes-field
    • 131472dc - Accept maintainer_note in REST runner registration

    Compare with previous version

  • Pedro Pombeiro deleted the pedropombeiro/348299/1-add-notes-field branch. This merge request now targets the master branch

    deleted the pedropombeiro/348299/1-add-notes-field branch. This merge request now targets the master branch

  • Pedro Pombeiro changed the description

    changed the description

  • Pedro Pombeiro requested review from @jprovaznik

    requested review from @jprovaznik

  • Pedro Pombeiro resolved all threads

    resolved all threads

  • Pedro Pombeiro added 116 commits

    added 116 commits

    Compare with previous version

  • A deleted user added documentation label

    added documentation label

  • Jan Provaznik approved this merge request

    approved this merge request

  • Jan Provaznik requested review from @sselhorn and removed review request for @jprovaznik

    requested review from @sselhorn and removed review request for @jprovaznik

  • Suzanne Selhorn approved this merge request

    approved this merge request

  • Suzanne Selhorn removed review request for @sselhorn

    removed review request for @sselhorn

  • Suzanne Selhorn requested review from @jprovaznik

    requested review from @jprovaznik

  • Jan Provaznik resolved all threads

    resolved all threads

  • Thanks @pedropombeiro, MWPS set :rocket:

  • Jan Provaznik enabled an automatic merge when the pipeline for 487bd339 succeeds

    enabled an automatic merge when the pipeline for 487bd339 succeeds

  • merged

  • Jan Provaznik mentioned in commit 7924137d

    mentioned in commit 7924137d

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Confirmed that this is working in production using gitlab-runner!3268 (merged) and checking the prod database.

  • mentioned in issue #350730 (closed)

  • Pedro Pombeiro mentioned in issue #351089

    mentioned in issue #351089

  • Please register or sign in to reply
    Loading